chore(stats)!: submit p0 telemetry in stats#2130
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoJun 18, 2026
Merged
chore(stats)!: submit p0 telemetry in stats#2130gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
Conversation
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
VianneyRuhlmann
force-pushed
the
vianney/decouple-telemetry-p0-send
branch
from
3c9df9f to
71f4830
Compare
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 19a8712 | Docs | Datadog PR Page | Give us feedback! |
VianneyRuhlmann
force-pushed
the
vianney/decouple-telemetry-p0-send
branch
from
71f4830 to
facbbc4
Compare
VianneyRuhlmann
changed the title
hoolioh
reviewed
Jun 18, 2026
|
|
||
| // Send dropped P0 stats directly to telemetry if available | ||
| #[cfg(all(not(target_arch = "wasm32"), feature = "telemetry"))] | ||
| if let Some(telemetry_client) = telemetry { |
Contributor
There was a problem hiding this comment.
Would it be a good idea to add a test asserting that stats are sent?
Contributor
Author
There was a problem hiding this comment.
I think it would be a bit heavy. There's a test with http mock in the telemetry component, I don't think it should be up to the caller to check that telemetry correctly sends the telemetry.
Eldolfin
approved these changes
Jun 18, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
vianney/decouple-telemetry-p0-send
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow sending css drop telemetry from the stats module to avoid returning the counts just for them to be included in the send payload telemetry struct.
Motivation
Simplify telemetry flow for css
Additional Notes
Remove
dropped_by_trace_filterfrom DroppedStats struct as it's no longer usedHow to test the change?
Describe here in detail how the change can be validated.