suggest: large suggestion to flake.nix#2136
Draft
Eldolfin wants to merge 3 commits into
Draft
Conversation
Mostly style changes and missing tools - format with alejandra for better readability - add missing cargo-nextest, rust-src component (for lsp), alejandra - use specialized pkg.mkShell instead of mkDerivation - remove hardeningDisable, not sure it's needed
|
yannham
reviewed
Jun 18, 2026
Comment on lines
+34
to
+43
| packages = [ | ||
| rust-toolchain | ||
| pkgs.rust-cbindgen | ||
| pkgs.cargo-nextest | ||
| pkgs.cmake | ||
| pkgs.autoconf | ||
| pkgs.automake | ||
| pkgs.libtool | ||
| pkgs.alejandra | ||
| ]; |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| packages = [ | |
| rust-toolchain | |
| pkgs.rust-cbindgen | |
| pkgs.cargo-nextest | |
| pkgs.cmake | |
| pkgs.autoconf | |
| pkgs.automake | |
| pkgs.libtool | |
| pkgs.alejandra | |
| ]; | |
| packages = with pkgs; [ | |
| rust-toolchain | |
| rust-cbindgen | |
| cargo-nextest | |
| cmake | |
| autoconf | |
| automake | |
| libtool | |
| alejandra | |
| ]; |
Contributor
Author
There was a problem hiding this comment.
I just changed it a bit to separate rust-toolchain in a separate list in case it ever becomes a package in nixpkgs so that it doesn't get overriden.
| overlays = [(import rust-overlay)]; | ||
| }; | ||
| mkShell = rust-toolchain: | ||
| pkgs.mkShell { |
Contributor
There was a problem hiding this comment.
I totally missed we didn't use mkShell in the previous PR, but just mkDerivation. This is the way to go indeed 👍
| [toolchain] | ||
| channel = "1.87.0" | ||
| components = ["rustfmt", "clippy"] | ||
| components = ["clippy", "rust-src"] |
Contributor
There was a problem hiding this comment.
Why this change? Doesn't this impact non Nix-users in some way?
Contributor
Author
There was a problem hiding this comment.
Because we never use the stable rustfmt anyway, also we need rust-src for rust-analyzer to allow go-to-definition to std functions.
I feel like the only impact it could've had is CI failing because it could not find rustfmt but as said above we don't use the stable rustfmt
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large suggestions for #2128