Repository navigation
fix: read the renamed results file and explain the issue counts - #2
Merged
Merged
Conversation
mbroecheler
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The DataSQRL agent now marks a run as successful when its final pass passes the tests, whatever the judges' issue score. It writes its results to
.datasqrl_agent_results.json, andissue_countis now an object with thetotaland a count for each severity. This PR updates the launcher and the skills to match.datasqrl-agent.shreads.datasqrl_agent_results.json. The--statusand--waitline shows the counts for each severity, for example3 issue(s) (0 critical, 1 high, 2 medium, 0 low) · score 35. A run with no judge shows no issue part.implementskill tells the agent how to explain the result: success means the tests pass, and the judges' issues are review notes that never fail a run.patch,progress,start, README and DATA_HANDLING.md use the new file name.Merge this after the agent image that writes
.datasqrl_agent_results.jsonis published.Area
scripts/datasqrl-agent.sh)scripts/datasqrl-cloud.sh)How did you test it?
Ran
datasqrl-agent.sh --statusin a test project against three cases: a run with judge issues, a run with no judge, and no results file. Each printed the expected line.Checklist
feat:,fix:ordocs:.github/check-plugin.shpasses