Skip to content

fix: read the renamed results file and explain the issue counts - #2

Merged
HasanAlpCaferoglu merged 2 commits into
mainfrom
fix/results-file-and-issue-counts
Oct 13, 2026
Merged

HasanAlpCaferoglu merged 2 commits into
mainfrom
fix/results-file-and-issue-counts

Conversation

@HasanAlpCaferoglu

Copy link
Copy Markdown
Collaborator

What does this change?

The DataSQRL agent now marks a run as successful when its final pass passes the tests, whatever the judges' issue score. It writes its results to .datasqrl_agent_results.json, and issue_count is now an object with the total and a count for each severity. This PR updates the launcher and the skills to match.

  • datasqrl-agent.sh reads .datasqrl_agent_results.json. The --status and --wait line shows the counts for each severity, for example 3 issue(s) (0 critical, 1 high, 2 medium, 0 low) · score 35. A run with no judge shows no issue part.
  • The implement skill tells the agent how to explain the result: success means the tests pass, and the judges' issues are review notes that never fail a run.
  • patch, progress, start, README and DATA_HANDLING.md use the new file name.

Merge this after the agent image that writes .datasqrl_agent_results.json is published.

Area

  • Skills
  • Launcher (scripts/datasqrl-agent.sh)
  • Cloud client (scripts/datasqrl-cloud.sh)
  • Manifests
  • CI
  • Docs

How did you test it?

Ran datasqrl-agent.sh --status in a test project against three cases: a run with judge issues, a run with no judge, and no results file. Each printed the expected line.

Checklist

  • The PR title starts with a type such as feat:, fix: or docs:
  • .github/check-plugin.sh passes
  • Skills contain no SQRL and no HTML comments
  • A launcher change that needs a new agent image option waits until that image is published
  • README or DATA_HANDLING.md is updated if behavior or data handling changed

@HasanAlpCaferoglu HasanAlpCaferoglu added enhancement New feature or request launcher scripts/datasqrl-agent.sh labels Oct 12, 2026
@HasanAlpCaferoglu
HasanAlpCaferoglu merged commit 79998b4 into main Oct 13, 2026
2 checks passed
@HasanAlpCaferoglu
HasanAlpCaferoglu deleted the fix/results-file-and-issue-counts branch October 13, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request launcher scripts/datasqrl-agent.sh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants