Repository navigation
fix: Read value-format metadata when the value contains the key fields - #436
Merged
Merged
Conversation
Signed-off-by: Mate Czagany <mate@datasqrl.com>
ferenc-csaky
approved these changes
Oct 28, 2026
ferenc-csaky
pushed a commit
that referenced
this pull request
Oct 29, 2026
#436) Signed-off-by: Mate Czagany <mate@datasqrl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
With
key.fieldsset and'value.fields-include' = 'ALL',kafka-safereturned NULL for value-format metadata columns, such asdebezium-json'svalue.source.timestamp. The metadata range started atkeyProjection.length + valueProjection.length, which counts the key fields twice. It now startsat the physical field count. Upstream has the same bug (FLINK-41255), and a TODO marks switching to its helper once that's released.
Area
flink-sql-runner)connectors)formats)stdlib)env-utils)testing)README.md,stdlib-docs)How did you test it?
Added a case to
SafeKafkaDynamicSourceTestthat fails without the fix (+I(42,Ada,null)instead of+I(42,Ada,m)).mvn test -pl connectors/kafka-safe-connectorpasses.Checklist
feat:,fix:ordocs:, optionally with a scope (e.g.fix(flexible-json):)mvn clean installpasses locally and the code is formatted withmvn spotless:applygiven_when_thennaming, AssertJ assertions)pom.xmlgit commit -s -S)README.mdandstdlib-docsare updated if user-facing behavior or functions changed🤖 Generated with Claude Code