Skip to content

fix(frontend): persist sidebar on host guide page and toggle fullscreen layout#599

Open
dembrane-sam-bot wants to merge 1 commit into
mainfrom
sam/host-guide-sidebar-persistence
Open

fix(frontend): persist sidebar on host guide page and toggle fullscreen layout#599
dembrane-sam-bot wants to merge 1 commit into
mainfrom
sam/host-guide-sidebar-persistence

Conversation

@dembrane-sam-bot
Copy link
Copy Markdown
Contributor

@dembrane-sam-bot dembrane-sam-bot commented May 27, 2026

Summary

Addresses feedback on the host guide page: when clicking "Host guide" link, the sidebar disappeared because the route was not nested under the main layout router children (BaseLayout).

This PR nests the <HostGuidePage /> route under the workspace-scoped layout children list in Router.tsx so the sidebar persists. It also modifies HostGuidePage.tsx container and toolbar styling to cleanly handle transitions between normal and fullscreen layouts.

What this changes

  • The sidebar now remains visible and persistent when navigate to the "Host guide" page — Router.tsx
  • Toggling "Fullscreen" on the Host guide page cleanly covers the viewport and hides the sidebar, restoring normal inline layout upon exit — HostGuidePage.tsx

Confidence

Confidence: high. Standard routing nested structure change and clean conditional style toggles on fullscreen state.

Refs: https://dembrane.slack.com/archives/C0884QPQF6W/p1779876000035059

Summary by CodeRabbit

  • Bug Fixes
    • Improved fullscreen mode display for HostGuidePage with proper viewport coverage and fixed header positioning.

Review Change Stack

@github-actions
Copy link
Copy Markdown

Hi @dembrane-sam-bot!

Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request.

Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bcd183e4-d0f8-4696-923c-5b8ea62967ce

📥 Commits

Reviewing files that changed from the base of the PR and between b12baf5 and a3869f6.

📒 Files selected for processing (2)
  • echo/frontend/src/Router.tsx
  • echo/frontend/src/routes/project/HostGuidePage.tsx

Walkthrough

Route nesting for HostGuidePage was reorganized under workspace-scoped children, and fullscreen layout styling was added with fixed positioning, viewport alignment, and scroll handling for the page container and toolbar.

Changes

HostGuidePage Fullscreen & Route Scoping

Layer / File(s) Summary
Route hierarchy adjustment
echo/frontend/src/Router.tsx
HostGuidePage route is moved into the same children block as ProjectsHomeRoute (home) under the /w/:workspaceId path, restructuring its nesting relative to sibling workspace routes.
Fullscreen layout styling
echo/frontend/src/routes/project/HostGuidePage.tsx
Main page container and header toolbar apply conditional fixed positioning, viewport sizing (top/left/width/height), elevated zIndex, and overflowY: "auto" scrolling when fullscreen mode is enabled.

🎯 2 (Simple) | ⏱️ ~8 minutes

bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: routing adjustment for sidebar persistence and fullscreen layout toggle in HostGuidePage, directly matching the file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sam/host-guide-sidebar-persistence

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the bug Something isn't working label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant