fix(frontend): persist sidebar on host guide page and toggle fullscreen layout#599
fix(frontend): persist sidebar on host guide page and toggle fullscreen layout#599dembrane-sam-bot wants to merge 1 commit into
Conversation
|
Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughRoute nesting for ChangesHostGuidePage Fullscreen & Route Scoping
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Addresses feedback on the host guide page: when clicking "Host guide" link, the sidebar disappeared because the route was not nested under the main layout router children (
BaseLayout).This PR nests the
<HostGuidePage />route under the workspace-scoped layoutchildrenlist inRouter.tsxso the sidebar persists. It also modifiesHostGuidePage.tsxcontainer and toolbar styling to cleanly handle transitions between normal and fullscreen layouts.What this changes
Router.tsxHostGuidePage.tsxConfidence
Confidence: high. Standard routing nested structure change and clean conditional style toggles on fullscreen state.
Refs: https://dembrane.slack.com/archives/C0884QPQF6W/p1779876000035059
Summary by CodeRabbit