Repository navigation
fix(hooks): give the codebase map 3 s so a slow Windows start keeps it - #1166
Merged
Merged
Conversation
Since #1082 the map child had 1 s, to keep a stalled map from costing the rules inside the 5 s hook limit (#1079). On a contended Windows start the map takes 1.5 to 2.3 s, so it was dropped every time. With the hook limit at 15 s (#1165) the map can have 3 s and a stalled one still never costs the rules. Cursor and Copilot run the same start hook, so their limits go to 15 s as well. Fixes #1157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1157
Since #1082 the map child had 1 s, so a stalled map could not cost the rules inside the 5 s hook limit (#1079). On a contended Windows start the map takes 1.5 to 2.3 s, so it was dropped every time.
With the hook limit at 15 s (#1165) the map can have 3 s, and a stalled map still never costs the rules.
hooks/ponytail-activate.js: map timeout 1 s to 3 s.hooks/cursor-hooks.json,hooks/copilot-hooks.json: 5 s to 15 s, since they run the same start hook.Checked with the repro from the issue and a
gitslowed by 2 s: on main the map is missing after 1 s, with this change it arrives after about 2.1 s. Withgitstalled for 10 s the hook still ends after 3 s with the rules.