Repository navigation
ci: run the test suite on Windows too - #1170
Open
devohmycode wants to merge 1 commit into
Open
devohmycode wants to merge 1 commit into
devohmycode wants to merge 1 commit into
Conversation
Windows has its own hook paths, shells and line endings (DietrichGebert#443, DietrichGebert#774, DietrichGebert#790), and the suite only ran on Ubuntu. The test job now runs on ubuntu-latest and windows-latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1142
Problem
test.ymlran onubuntu-latestonly, so Windows-only breakages (#1046, #1124) landed unnoticed.Fix
A matrix on
[ubuntu-latest, windows-latest]for the test job. The steps stay the same.Checks
main(with fix(bench): wait for the killed todo server before the workdir cleanup #1116 and ci: run agentic benchmark selftest in test workflow #1154): both jobs pass. Onwindows-latest, all 144 tests and the 30 pi tests pass, none skipped, andpython3 benchmarks/agentic/run.py --selftestreports all instruments valid.publish.ymlhasneeds: test, so a release now waits for the Windows job too.