Repository navigation
metrics: bound label values and cap cardinality - #776
Open
Alisadev-dev wants to merge 2 commits into
Open
Alisadev-dev wants to merge 2 commits into
Alisadev-dev wants to merge 2 commits into
Conversation
Contributor
|
@Alisadev-dev make sure to reference the issue you worked on in the pull request description |
Wallet/claim/CID/URL/error values could become Prometheus labels via the domain counters and the HTTP middleware. Route every label through a small allowlist policy that collapses unbounded values to other, cap distinct values per label, and expose a scrape budget assertion for CI. Also stop using the raw req.path as a route label for unmatched requests. Document metric names/units and the label policy.
Author
|
my bad sorry about that, it is fixed now |
Alisadev-dev
force-pushed
the
fix/metrics-label-cardinality
branch
from
October 19, 2026 09:37
839bf2a to
34a66cc
Compare
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Author
|
Please kindly review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet/claim/CID/URL/error values could become Prometheus labels via the domain counters and the HTTP middleware.
This routes every label through a small allowlist policy that collapses unbounded values to "other", caps distinct values per label, and adds a scrape budget assertion for CI. Unmatched HTTP requests no longer use raw
eq.path as a route label. Metric names/units and the label policy are documented.
Tests cover wallet/claim/error injection, high-cardinality load, secret canaries, histogram boundary and scrape budget.
Closes #665