Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Implementation and description were produced with an LLM tool, directed and reviewed by the requester.
Layout::height()was the sum of each line'sline_height, so a gap from moving a line down withBreakerState::set_line_y(e.g. below a float) was not counted. The height is now the bottom of the bottom-most non-empty line (line_yafter the line, tracked as a max inBreakerState), so it's unchanged when lines aren't moved. Usingblock_max_coordinstead was tried but changes heights under quantization (it's rounded), failing the line-height tests.Adds a test that fails without the fix.
Changelog
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/f92c4595b47c4ea7b04a008d6d8f08cf
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/f92c4595b47c4ea7b04a008d6d8f08cf?variant=devin-insiders