Skip to content

Include lines moved down with set_line_y in layout height - #100

Open
nicoburns wants to merge 1 commit into
mainfrom
layout-height-moved-lines
Open

nicoburns wants to merge 1 commit into
mainfrom
layout-height-moved-lines

Conversation

@nicoburns

Copy link
Copy Markdown
Member

LLM Contributions: Implementation and description were produced with an LLM tool, directed and reviewed by the requester.

Layout::height() was the sum of each line's line_height, so a gap from moving a line down with BreakerState::set_line_y (e.g. below a float) was not counted. The height is now the bottom of the bottom-most non-empty line (line_y after the line, tracked as a max in BreakerState), so it's unchanged when lines aren't moved. Using block_max_coord instead was tried but changes heights under quantization (it's rounded), failing the line-height tests.

Adds a test that fails without the fix.

Changelog

Fixed

  • Layout::height() now includes gaps from lines moved down with BreakerState::set_line_y.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/f92c4595b47c4ea7b04a008d6d8f08cf
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/f92c4595b47c4ea7b04a008d6d8f08cf?variant=devin-insiders

@staging-devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant