Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Investigation, implementation, tests.
CSS Text 3 § 5.1 says the
white-spaceof the nearest common ancestor of two characters (or atomic inlines) controls the soft wrap opportunity between them. The line breaker uses the wrap mode of the character before each opportunity. Since linebender#902 turned inline boxes into U+FFFC characters, that gets<span nowrap><img></span><span nowrap><img></span>in a wrappable parent wrong: no break is allowed between the images.TreeStyleBuildernow remembers the span of the last committed character. When content is committed to a different span and only their common ancestor allows wrapping, it gives that last character its span's wrappable style variant (thewrappable_style_idmechanism collapsed whitespace already uses). Preserved whitespace keeps its style, because whether it hangs depends on its own wrap mode.In Blitz this fixes WPT css/css-text/line-breaking/line-breaking-030, 031, 032, ic-001, ic-003, white-space/white-space-wrap-after-nowrap-001 and word-break/break-boundary-2-chars-001. Nothing regressed across css-text, CSS2, cssom-view, css-flexbox and css-inline (about 10.5k tests).
Changelog
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/3495a07b81e84e958badc4170c5717af
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/3495a07b81e84e958badc4170c5717af?variant=devin-insiders