Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1793668880-fontconfig-metric-aliases
branch
from
November 3, 2026 01:31
528e311 to
8d8b99e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: code and description written by Devin; rewrite the description in your own words before upstreaming to linebender/parley.
On Linux, fontique only knows the family names of installed fonts, so
font-family: Helvetica,Times,ArialorTimes New Romanon a machine without them falls through to the generic default (DejaVu Sans, even for Times). Chrome follows fontconfig's metric aliases and renders them with Liberation Sans/Serif.At startup, for each name in fontconfig's
30-metric-aliases.confgroups that isn't installed,add_metric_compatible_aliasesasks fontconfig for its match and, only when that match is in the same metric-compatible group, adds the name as an alias of the matched family. Fontconfig's catch-all default (e.g. DejaVu Sans for an unknown name) is never aliased, so other missing names still fall through to the CSS fallback list.Measured in Blitz against Chrome 156 on Ubuntu: text widths for Helvetica, Times, Arial and Times New Roman now match Chrome (315/291px vs 358px before) and the mean pixel difference per line is under 1/255.
One case this doesn't cover: when a Type 1
Courier(pcrr8a.pfb, from gsfonts/TeX) is installed, the name exists but fontique can't load it, so Courier still falls back to DejaVu Sans while Chrome uses Liberation Mono.Changelog
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/ce5c4353702746cd821bfeb3812bfd37
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/ce5c4353702746cd821bfeb3812bfd37?variant=devin-insiders