Repository navigation
Use immutable filter snapshots and narrow configuration reads - #226
Open
SlimShadyIAm wants to merge 1 commit into
Open
SlimShadyIAm wants to merge 1 commit into
SlimShadyIAm wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter commands now update individual flags atomically rather than mutating shared cached documents before persistence. Immutable precomputed snapshots preserve live policy on failed writes, and successful cancelled writes still invalidate stale cache entries.
Concurrent cache misses share one refresh. CIJ guidance validates every consumed field and retains the last good feed on outages. Narrow projections avoid loading unrelated guild content for counters, tag/meme retrieval, configuration values, and autocomplete. Existing Unicode, bypass, ordering, and distinct word/raid semantics are covered by regressions.
Validation: reviewer independently ran 67 tests (63 passed, 4 Mongo-only skips), compilation, and whitespace checks. Remote CI includes the non-first positional update case that mongomock cannot faithfully exercise.
Limits: scalar settings remain uncached because broad-document writers do not yet provide complete invalidation. Initial CIJ outages coalesce concurrent requests but retry later sequential requests; last-good fallback backs off for 30 seconds. No production speedup claim, schema migration, or live changes.
Audit-fix chunk 3/7, independently based on main de3b507.