Repository navigation
build: update Node.js to 24.22.1 security release - #5729
Closed
philippgerard wants to merge 4 commits into
Closed
philippgerard wants to merge 4 commits into
philippgerard wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mateuskb
approved these changes
Oct 22, 2026
erwannbst
approved these changes
Oct 22, 2026
DaftVadeR
approved these changes
Oct 22, 2026
3 tasks done
Collaborator
|
Thanks a lot for this, @philippgerard, and for the really thorough testing! Runtime security updates are shipped from the Dokploy team, so we've opened #5738 with the same Node.js 24.22.1 bump and are closing this one in favor of it. Really appreciate you flagging it so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Updates Dokploy's Node.js runtime from 24.4.0 to 24.22.1 to consume the October 21 Node security release. All four production Dockerfiles, CI pins, development tooling, contributor instructions, and workspace Node engine requirements now agree on the patched version.
Production images explicitly use
node:24.22.1-bookworm-slim, preserving their Debian Bookworm base. The devcontainer moves from Bullseye to Bookworm because the new Node release has no Bullseye image. pnpm remains 10.22.0; application dependencies, lockfiles, and application logic are unchanged. The remaining@types/noderanges select TypeScript declarations, not the runtime.This consumes a public upstream fix; it does not claim a demonstrated Dokploy-specific exploit.
Validation
Local Linux containers: native arm64 and emulated amd64.
Dockerfilefor both amd64 and arm64; builtDockerfile.cloud,Dockerfile.server, andDockerfile.schedulefor amd64; built the devcontainer for arm64.pnpm typecheckpassed.pnpm --dir apps/dokploy exec vitest run --config __test__/vitest.config.ts --maxWorkers=2: 134 files passed; 1,302 tests passed, 1 existing test skipped. Docker-dependent tests used an isolated Docker Swarm with the configured Nixpacks and Railpack versions.git diff --checkpassed. Independent read-only review found no actionable bypass or regression in this diff.Next builds logged database-resolution warnings with no build-time PostgreSQL; the actual runtime startup checks completed without migration or initialization errors. External Inngest/SMTP/OAuth integrations and the complete VS Code devcontainer feature setup were not exercised.
Checklist
canary.Issues related
Closes #5727


Confidence Score: 5/5
The PR appears safe to merge; no actionable regression was found.Summary
Updates Node.js from 24.4.0 to 24.22.1 across production images, CI, development tooling, contributor instructions, and workspace engine requirements.
Reviews (1) · Last reviewed commit: "build: update Node.js to 24.22.1 securit..." · Reviewed by Greptile