Skip to content

fix(deploy): preserve remote serverId in webhook deployment jobs - #5732

Merged
Siumauricio merged 1 commit into
Dokploy:canaryfrom
Totopo27:fix/gh-5659-webhook-remote-server-concurrency
Oct 22, 2026
Merged

Siumauricio merged 1 commit into
Dokploy:canaryfrom
Totopo27:fix/gh-5659-webhook-remote-server-concurrency

Conversation

@Totopo27

@Totopo27 Totopo27 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Closes #5659

Summary

When a deployment was queued via Git/GitHub webhooks on self-hosted instances, \jobData.serverId\ was only assigned within the \if (IS_CLOUD && app.serverId)\ block. On self-hosted setups, the job was queued without \serverId, causing \in-memory-queue\ to partition it into _local_\ and apply the web server's concurrency limit instead of the remote server's \�uildsConcurrency.

Changes

  • Explicitly set \serverId: app.serverId ?? undefined\ (and for compose apps) when constructing \jobData\ across webhook handlers (\github.ts, [refreshToken].ts, \compose/[refreshToken].ts).
  • Added unit test in \github-webhook-handler.test.ts\ verifying that \serverId\ is passed to \myQueue.add.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

This PR preserves serverId when webhook handlers create deployment jobs.

  • Webhook deployment jobs keep their remote server target.

Reviews (1) · Last reviewed commit: "fix(deploy): preserve remote serverId in..." · Reviewed by Greptile

@Totopo27
Totopo27 requested a review from Siumauricio as a code owner October 22, 2026 00:16
@Siumauricio
Siumauricio merged commit 9c06e34 into Dokploy:canary Oct 22, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook (git push) deploys ignore the remote server's Builds Concurrency on self-hosted

2 participants