Check that constraint exists. Close #22.

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP004ParameterSyntaxTests/CodeFix.cs

@@ -11,15 +11,15 @@ public class CodeFix
         private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(ASP004ParameterSyntax.Descriptor);
         private static readonly CodeFixProvider Fix = new ParameterSyntaxFix();
 
-        [TestCase("api/orders/↓id:long}",          "api/orders/{id:long}")]
-        [TestCase("api/orders/↓{id:long",          "api/orders/{id:long}")]
-        [TestCase("api/orders/{id:min(1}",         "api/orders/{id:min(1)}")]
-        [TestCase("api/orders/{id:max(1}",         "api/orders/{id:max(1)}")]
-        [TestCase("api/orders/{id:minlength(1}",   "api/orders/{id:minlength(1)}")]
-        [TestCase("api/orders/{id:maxlength(1}",   "api/orders/{id:maxlength(1)}")]
-        [TestCase("api/orders/{id:length(1}",      "api/orders/{id:length(1)}")]
-        [TestCase("api/orders/{id:length(1,2}",    "api/orders/{id:length(1,2)}")]
-        [TestCase("api/orders/{id:range(1,2}",     "api/orders/{id:range(1,2)}")]
+        [TestCase("api/orders/↓id:long}", "api/orders/{id:long}")]
+        [TestCase("api/orders/↓{id:long", "api/orders/{id:long}")]
+        [TestCase("api/orders/{id:min(1}", "api/orders/{id:min(1)}")]
+        [TestCase("api/orders/{id:max(1}", "api/orders/{id:max(1)}")]
+        [TestCase("api/orders/{id:minlength(1}", "api/orders/{id:minlength(1)}")]
+        [TestCase("api/orders/{id:maxlength(1}", "api/orders/{id:maxlength(1)}")]
+        [TestCase("api/orders/{id:length(1}", "api/orders/{id:length(1)}")]
+        [TestCase("api/orders/{id:length(1,2}", "api/orders/{id:length(1,2)}")]
+        [TestCase("api/orders/{id:range(1,2}", "api/orders/{id:range(1,2)}")]
         [TestCase("api/orders/{id:regex((a|b)-c}", "api/orders/{id:regex((a|b)-c)}")]
         public void WhenFixable(string before, string after)
         {
@@ -56,5 +56,29 @@ public IActionResult GetId(long id)
 }".AssertReplace("api/orders/{id:long}", after);
             AnalyzerAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, code, fixedCode);
         }
+
+        [TestCase("api/orders/{id:↓wrong}")]
+        [TestCase("api/orders/{id:min1)}")]
+        [TestCase("api/orders/{id:max1)}")]
+        public void WhenNot(string before)
+        {
+            var code = @"
+namespace ValidCode
+{
+    using Microsoft.AspNetCore.Mvc;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        [HttpGet(""api/orders/↓{id:wrong}"")]
+        public IActionResult GetId(long id)
+        {
+            return this.Ok(id);
+        }
+    }
+}".AssertReplace("api/orders/↓{id:wrong}", before);
+
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
+        }
     }
 }

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -240,6 +240,29 @@ private static bool HasWrongSyntax(PathSegment segment, out Location location, o
                             return true;
                         }
                     }
+
+                    if (!text.Equals("int", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("bool", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("datetime", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("decimal", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("double", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("float", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("guid", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("long", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("alpha", StringComparison.OrdinalIgnoreCase) &&
+                        !text.Equals("required", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("minlength(", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("maxlength(", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("length(", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("min(", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("max(", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("regex(", StringComparison.OrdinalIgnoreCase) &&
+                        !text.StartsWith("range(", StringComparison.OrdinalIgnoreCase))
+                    {
+                        location = constraint.Span.GetLocation();
+                        correctSyntax = null;
+                        return true;
+                    }
                 }
             }
             else

AspNetCoreAnalyzers/Helpers/Text.cs

@@ -11,6 +11,18 @@ public static void SkipWhiteSpace(string text, ref int pos)
             }
         }
 
+        public static bool TrySkipDigits(string text, ref int pos)
+        {
+            var before = pos;
+            while (pos < text.Length &&
+                  char.IsDigit(text[pos]))
+            {
+                pos++;
+            }
+
+            return pos != before;
+        }
+
         public static bool TrySkipPast(string text, ref int pos, string substring)
         {
             var before = pos;