Skip to content

Commit 5a8138b

Browse files
JohanLarssonJohanLarsson
committed
Fix warnings.
1 parent 29b410c commit 5a8138b

7 files changed

Lines changed: 27 additions & 29 deletions

‎PropertyChangedAnalyzers.Test/Helpers/PropertyChangedTest.FindPropertyName.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
269269
}
270270
}
271271
}".AssertReplace("propertyName ?? string.Empty", expression));
272-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
272+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
273273
var semanticModel = compilation.GetSemanticModel(syntaxTree);
274274
var invocation = syntaxTree.FindInvocation("this.OnPropertyChanged();");
275275
var findPropertyName = PropertyChanged.FindPropertyName(invocation, semanticModel, CancellationToken.None);

‎PropertyChangedAnalyzers.Test/Helpers/PropertyChangedTest.InvokesPropertyChangedFor.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
namespace PropertyChangedAnalyzers.Test.Helpers
1+
namespace PropertyChangedAnalyzers.Test.Helpers
22
{
33
using System.Threading;
44
using Gu.Roslyn.Asserts;
@@ -104,7 +104,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
104104
}
105105
}
106106
}");
107-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
107+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
108108
var semanticModel = compilation.GetSemanticModel(syntaxTree);
109109
var node = syntaxTree.Find<ExpressionSyntax>(signature);
110110
var property = semanticModel.GetDeclaredSymbol(syntaxTree.FindPropertyDeclaration(propertyName));
@@ -159,7 +159,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
159159
}".AssertReplace("this.TrySet(ref this.p, value)", trySetCode);
160160

161161
var syntaxTree = CSharpSyntaxTree.ParseText(code);
162-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
162+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
163163
var semanticModel = compilation.GetSemanticModel(syntaxTree);
164164
var node = syntaxTree.FindArgument("ref this.p");
165165
var property = semanticModel.GetDeclaredSymbol(syntaxTree.FindPropertyDeclaration("P"));
@@ -213,7 +213,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
213213
}".AssertReplace("this.TrySet(ref this.p, value, nameof(P))", trySetCode);
214214

215215
var syntaxTree = CSharpSyntaxTree.ParseText(code);
216-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
216+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
217217
var semanticModel = compilation.GetSemanticModel(syntaxTree);
218218
var node = syntaxTree.FindArgument("ref this.p");
219219
var property = semanticModel.GetDeclaredSymbol(syntaxTree.FindPropertyDeclaration("P"));
@@ -314,7 +314,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
314314
}
315315
}
316316
}");
317-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
317+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
318318
var semanticModel = compilation.GetSemanticModel(syntaxTree);
319319
var node = syntaxTree.Find<ExpressionSyntax>(signature);
320320
var property = semanticModel.GetDeclaredSymbol(syntaxTree.FindPropertyDeclaration(propertyName));

‎PropertyChangedAnalyzers.Test/Helpers/PropertyTests.ShouldNotify.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
namespace PropertyChangedAnalyzers.Test.Helpers
1+
namespace PropertyChangedAnalyzers.Test.Helpers
22
{
33
using System.Threading;
44
using Gu.Roslyn.Asserts;
@@ -58,7 +58,7 @@ public void Mutate()
5858
this.P10 = 2;
5959
}
6060
}");
61-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
61+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
6262
var semanticModel = compilation.GetSemanticModel(syntaxTree);
6363
var propertyDeclaration = syntaxTree.FindPropertyDeclaration(propertyName);
6464
var propertySymbol = semanticModel.GetDeclaredSymbol(propertyDeclaration);
@@ -117,7 +117,7 @@ public void Mutate()
117117
}
118118
}
119119
}");
120-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
120+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
121121
var semanticModel = compilation.GetSemanticModel(syntaxTree);
122122
var propertyDeclaration = syntaxTree.FindPropertyDeclaration(propertyName);
123123
var propertySymbol = semanticModel.GetDeclaredSymbol(propertyDeclaration);
@@ -148,7 +148,7 @@ public C()
148148
}".AssertReplace("this.P = 1", assignCode);
149149

150150
var syntaxTree = CSharpSyntaxTree.ParseText(code);
151-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
151+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
152152
var semanticModel = compilation.GetSemanticModel(syntaxTree);
153153
var propertyDeclaration = syntaxTree.FindPropertyDeclaration("P");
154154
var propertySymbol = semanticModel.GetDeclaredSymbol(propertyDeclaration);

‎PropertyChangedAnalyzers.Test/Helpers/PropertyTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public int P5
9797
}
9898
}
9999
}");
100-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
100+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
101101
var semanticModel = compilation.GetSemanticModel(syntaxTree);
102102
var property = syntaxTree.FindPropertyDeclaration(code);
103103
Assert.AreEqual(expected, Property.IsLazy(property, semanticModel, CancellationToken.None));

‎PropertyChangedAnalyzers.Test/Helpers/SetterTests.FindBackingField.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public int P2
3535
}
3636
}
3737
}");
38-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
38+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
3939
var semanticModel = compilation.GetSemanticModel(syntaxTree);
4040
var property = syntaxTree.FindPropertyDeclaration(propertyName);
4141
Assert.AreEqual(true, property.TryGetSetter(out var setter));
@@ -60,7 +60,7 @@ public int P
6060
}
6161
}
6262
}");
63-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
63+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
6464
var semanticModel = compilation.GetSemanticModel(syntaxTree);
6565
var property = syntaxTree.FindPropertyDeclaration("P");
6666
Assert.AreEqual(true, property.TryGetSetter(out var setter));
@@ -107,7 +107,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
107107
}
108108
}
109109
}");
110-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
110+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
111111
var semanticModel = compilation.GetSemanticModel(syntaxTree);
112112
var property = syntaxTree.FindPropertyDeclaration("P");
113113
Assert.AreEqual(true, property.TryGetSetter(out var setter));
@@ -152,7 +152,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
152152
}
153153
}
154154
}");
155-
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, MetadataReferences.FromAttributes());
155+
var compilation = CSharpCompilation.Create("test", new[] { syntaxTree }, Settings.Default.MetadataReferences);
156156
var semanticModel = compilation.GetSemanticModel(syntaxTree);
157157
var property = syntaxTree.FindPropertyDeclaration("P");
158158
Assert.AreEqual(true, property.TryGetSetter(out var setter));

‎PropertyChangedAnalyzers.Test/Helpers/TrySetTests.Find.cs‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
namespace PropertyChangedAnalyzers.Test.Helpers
22
{
3-
using System.Linq;
43
using System.Threading;
54
using Gu.Roslyn.Asserts;
65
using Microsoft.CodeAnalysis.CSharp;
@@ -46,7 +45,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
4645
var compilation = CSharpCompilation.Create(
4746
"test",
4847
new[] { syntaxTree },
49-
MetadataReferences.FromAttributes());
48+
Settings.Default.MetadataReferences);
5049
var semanticModel = compilation.GetSemanticModel(syntaxTree);
5150
var typeDeclaration = syntaxTree.FindClassDeclaration("ViewModelBase");
5251
var type = semanticModel.GetDeclaredSymbol(typeDeclaration);
@@ -104,7 +103,7 @@ protected virtual bool TrySet<T>(ref T field, T value, Action OnChanging = null,
104103
var compilation = CSharpCompilation.Create(
105104
"test",
106105
new[] { syntaxTree },
107-
MetadataReferences.FromAttributes());
106+
Settings.Default.MetadataReferences);
108107
var semanticModel = compilation.GetSemanticModel(syntaxTree);
109108
var typeDeclaration = syntaxTree.FindClassDeclaration("ObservableObject");
110109
var type = semanticModel.GetDeclaredSymbol(typeDeclaration);
@@ -129,7 +128,7 @@ public override bool Set<T>(ref T oldValue, T value, string propertyName = null)
129128
var compilation = CSharpCompilation.Create(
130129
"test",
131130
new[] { syntaxTree },
132-
MetadataReferences.FromAttributes().Concat(MetadataReferences.Transitive(typeof(Caliburn.Micro.PropertyChangedBase).Assembly)));
131+
LibrarySettings.CaliburnMicro.MetadataReferences);
133132
var semanticModel = compilation.GetSemanticModel(syntaxTree);
134133
var typeDeclaration = syntaxTree.FindClassDeclaration("ViewModelBase");
135134
var type = semanticModel.GetDeclaredSymbol(typeDeclaration);
@@ -154,7 +153,7 @@ public bool TrySet<T>(ref T oldValue, T value, string propertyName = null)
154153
var compilation = CSharpCompilation.Create(
155154
"test",
156155
new[] { syntaxTree },
157-
MetadataReferences.FromAttributes().Concat(MetadataReferences.Transitive(typeof(Caliburn.Micro.PropertyChangedBase).Assembly)));
156+
LibrarySettings.CaliburnMicro.MetadataReferences);
158157
var semanticModel = compilation.GetSemanticModel(syntaxTree);
159158
var typeDeclaration = syntaxTree.FindClassDeclaration("ViewModelBase");
160159
var type = semanticModel.GetDeclaredSymbol(typeDeclaration);
@@ -194,7 +193,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
194193
var compilation = CSharpCompilation.Create(
195194
"test",
196195
new[] { syntaxTree },
197-
MetadataReferences.FromAttributes());
196+
Settings.Default.MetadataReferences);
198197
var semanticModel = compilation.GetSemanticModel(syntaxTree);
199198
var typeDeclaration = syntaxTree.FindClassDeclaration("ViewModelBase");
200199
var type = semanticModel.GetDeclaredSymbol(typeDeclaration);
@@ -229,7 +228,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
229228
var compilation = CSharpCompilation.Create(
230229
"test",
231230
new[] { syntaxTree },
232-
MetadataReferences.FromAttributes());
231+
Settings.Default.MetadataReferences);
233232
var semanticModel = compilation.GetSemanticModel(syntaxTree);
234233
var typeDeclaration = syntaxTree.FindClassDeclaration("ViewModelBase");
235234
var type = semanticModel.GetDeclaredSymbol(typeDeclaration);

‎PropertyChangedAnalyzers.Test/Helpers/TrySetTests.IsMatchMethod.cs‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
namespace PropertyChangedAnalyzers.Test.Helpers
22
{
3-
using System.Linq;
43
using System.Threading;
54
using Gu.Roslyn.AnalyzerExtensions;
65
using Gu.Roslyn.Asserts;
@@ -128,7 +127,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
128127
var compilation = CSharpCompilation.Create(
129128
"test",
130129
new[] { syntaxTree },
131-
MetadataReferences.FromAttributes());
130+
Settings.Default.MetadataReferences);
132131
var semanticModel = compilation.GetSemanticModel(syntaxTree);
133132
var methodDeclaration = syntaxTree.FindMethodDeclaration("TrySet");
134133
var method = semanticModel.GetDeclaredSymbol(methodDeclaration);
@@ -186,7 +185,7 @@ protected virtual bool TrySet<T>(ref T field, T value, Action OnChanging = null,
186185
var compilation = CSharpCompilation.Create(
187186
"test",
188187
new[] { syntaxTree },
189-
MetadataReferences.FromAttributes());
188+
Settings.Default.MetadataReferences);
190189
var semanticModel = compilation.GetSemanticModel(syntaxTree);
191190
var methodDeclaration = syntaxTree.FindMethodDeclaration("TrySet");
192191
var method = semanticModel.GetDeclaredSymbol(methodDeclaration);
@@ -211,7 +210,7 @@ public override bool Set<T>(ref T oldValue, T value, string propertyName = null)
211210
var compilation = CSharpCompilation.Create(
212211
"test",
213212
new[] { syntaxTree },
214-
MetadataReferences.FromAttributes().Concat(MetadataReferences.Transitive(typeof(Caliburn.Micro.PropertyChangedBase).Assembly)));
213+
LibrarySettings.CaliburnMicro.MetadataReferences);
215214
var semanticModel = compilation.GetSemanticModel(syntaxTree);
216215
var methodDeclaration = syntaxTree.FindMethodDeclaration("Set");
217216
var method = semanticModel.GetDeclaredSymbol(methodDeclaration);
@@ -236,7 +235,7 @@ public bool TrySet<T>(ref T oldValue, T value, string propertyName = null)
236235
var compilation = CSharpCompilation.Create(
237236
"test",
238237
new[] { syntaxTree },
239-
MetadataReferences.FromAttributes().Concat(MetadataReferences.Transitive(typeof(Caliburn.Micro.PropertyChangedBase).Assembly)));
238+
LibrarySettings.CaliburnMicro.MetadataReferences);
240239
var semanticModel = compilation.GetSemanticModel(syntaxTree);
241240
var methodDeclaration = syntaxTree.FindMethodDeclaration("TrySet");
242241
var method = semanticModel.GetDeclaredSymbol(methodDeclaration);
@@ -276,7 +275,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
276275
var compilation = CSharpCompilation.Create(
277276
"test",
278277
new[] { syntaxTree },
279-
MetadataReferences.FromAttributes());
278+
Settings.Default.MetadataReferences);
280279
var semanticModel = compilation.GetSemanticModel(syntaxTree);
281280
var methodDeclaration = syntaxTree.FindMethodDeclaration("TrySet");
282281
var method = semanticModel.GetDeclaredSymbol(methodDeclaration);
@@ -311,7 +310,7 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
311310
var compilation = CSharpCompilation.Create(
312311
"test",
313312
new[] { syntaxTree },
314-
MetadataReferences.FromAttributes());
313+
Settings.Default.MetadataReferences);
315314
var semanticModel = compilation.GetSemanticModel(syntaxTree);
316315
var methodDeclaration = syntaxTree.FindMethodDeclaration("TrySet");
317316
var method = semanticModel.GetDeclaredSymbol(methodDeclaration);

0 commit comments

Comments
 (0)