Enable SA1305 (FieldNamesMustNotUseHungarianNotation) and fix all violations

sharwell · sharwell · commit 4a7f79dfac92 · 2015-09-26T19:12:15.000-05:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.ruleset b/StyleCop.Analyzers/StyleCop.Analyzers.ruleset
@@ -90,6 +90,7 @@
     <Rule Id="SA1302" Action="Error" />
     <Rule Id="SA1303" Action="Error" />
     <Rule Id="SA1304" Action="Error" />
+    <Rule Id="SA1305" Action="Warning" />
     <Rule Id="SA1309" Action="Error" />
     <Rule Id="SA1311" Action="Error" />
     <Rule Id="SA1400" Action="Error" />
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/XmlCommentHelper.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/XmlCommentHelper.cs
@@ -95,10 +95,10 @@ internal static bool IsConsideredEmpty(XmlNodeSyntax xmlSyntax)
                 return true;
             }
 
-            var cDataElement = xmlSyntax as XmlCDataSectionSyntax;
-            if (cDataElement != null)
+            var cdataElement = xmlSyntax as XmlCDataSectionSyntax;
+            if (cdataElement != null)
             {
-                foreach (SyntaxToken token in cDataElement.TextTokens)
+                foreach (SyntaxToken token in cdataElement.TextTokens)
                 {
                     if (!string.IsNullOrWhiteSpace(token.ToString()))
                     {

Original file line number	Diff line number	Diff line change
`@@ -95,10 +95,10 @@ internal static bool IsConsideredEmpty(XmlNodeSyntax xmlSyntax)`
`95`	`95`	`return true;`
`96`	`96`	`}`
`97`	`97`
`98`		`- var cDataElement = xmlSyntax as XmlCDataSectionSyntax;`
`99`		`- if (cDataElement != null)`
	`98`	`+ var cdataElement = xmlSyntax as XmlCDataSectionSyntax;`
	`99`	`+ if (cdataElement != null)`
`100`	`100`	`{`
`101`		`- foreach (SyntaxToken token in cDataElement.TextTokens)`
	`101`	`+ foreach (SyntaxToken token in cdataElement.TextTokens)`
`102`	`102`	`{`
`103`	`103`	`if (!string.IsNullOrWhiteSpace(token.ToString()))`
`104`	`104`	`{`