Merge pull request #3188 from sharwell/update-analyzers

Update Microsoft.CodeAnalysis.Analyzers

Author: sharwell

StyleCop.Analyzers/Directory.Build.props

@@ -46,6 +46,7 @@
     <PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" PrivateAssets="all" />
     <PackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" Version="1.0.0-beta.46" PrivateAssets="all" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.66" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.0" PrivateAssets="all" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="3.6.0-4.20251.5" PrivateAssets="all" />
   </ItemGroup>
 

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/NamingRules/SA1302CodeFixProvider.cs

@@ -28,6 +28,13 @@ internal class SA1302CodeFixProvider : CodeFixProvider
         public override ImmutableArray<string> FixableDiagnosticIds { get; } =
             ImmutableArray.Create(SA1302InterfaceNamesMustBeginWithI.DiagnosticId);
 
+        /// <inheritdoc/>
+        public override FixAllProvider GetFixAllProvider()
+        {
+            // Fix All is not yet supported
+            return null;
+        }
+
         /// <inheritdoc/>
         public override Task RegisterCodeFixesAsync(CodeFixContext context)
         {

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/NamingRules/SA1314CodeFixProvider.cs

@@ -26,6 +26,13 @@ internal class SA1314CodeFixProvider : CodeFixProvider
         public override ImmutableArray<string> FixableDiagnosticIds { get; } =
             ImmutableArray.Create(SA1314TypeParameterNamesMustBeginWithT.DiagnosticId);
 
+        /// <inheritdoc/>
+        public override FixAllProvider GetFixAllProvider()
+        {
+            // Fix All is not yet supported
+            return null;
+        }
+
         /// <inheritdoc/>
         public override Task RegisterCodeFixesAsync(CodeFixContext context)
         {

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/NamingRules/SA1316CodeFixProvider.cs

@@ -24,6 +24,13 @@ internal class SA1316CodeFixProvider : CodeFixProvider
         public override ImmutableArray<string> FixableDiagnosticIds { get; } =
             ImmutableArray.Create(SA1316TupleElementNamesShouldUseCorrectCasing.DiagnosticId);
 
+        /// <inheritdoc/>
+        public override FixAllProvider GetFixAllProvider()
+        {
+            // Fix All is not yet supported
+            return null;
+        }
+
         /// <inheritdoc/>
         public override Task RegisterCodeFixesAsync(CodeFixContext context)
         {

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1141CodeFixProvider.cs

@@ -25,6 +25,13 @@ internal class SA1141CodeFixProvider : CodeFixProvider
         public override ImmutableArray<string> FixableDiagnosticIds { get; } =
             ImmutableArray.Create(SA1141UseTupleSyntax.DiagnosticId);
 
+        /// <inheritdoc/>
+        public override FixAllProvider GetFixAllProvider()
+        {
+            // Fix All is not yet supported
+            return null;
+        }
+
         /// <inheritdoc/>
         public override Task RegisterCodeFixesAsync(CodeFixContext context)
         {
@@ -125,7 +132,7 @@ private static SyntaxNode TransformArgumentListToTuple(SemanticModel semanticMod
                 var argument = arguments[i];
 
                 var argumentTypeInfo = semanticModel.GetTypeInfo(argument.Expression);
-                if (argumentTypeInfo.Type != argumentTypeInfo.ConvertedType)
+                if (!Equals(argumentTypeInfo.Type, argumentTypeInfo.ConvertedType))
                 {
                     var expectedType = SyntaxFactory.ParseTypeName(argumentTypeInfo.ConvertedType.ToDisplayString());
                     argument = argument.WithExpression(SyntaxFactory.CastExpression(expectedType, argument.Expression));

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1142CodeFixProvider.cs

@@ -59,7 +59,7 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
         private static SyntaxNode GetReplacementNode(SemanticModel semanticModel, SyntaxNode fieldName)
         {
             var fieldSymbol = (IFieldSymbol)semanticModel.GetSymbolInfo(fieldName.Parent).Symbol;
-            var fieldNameSymbol = fieldSymbol.ContainingType.GetMembers().OfType<IFieldSymbol>().Single(fs => (fs != fieldSymbol) && (fs.CorrespondingTupleField() == fieldSymbol));
+            var fieldNameSymbol = fieldSymbol.ContainingType.GetMembers().OfType<IFieldSymbol>().Single(fs => !Equals(fs, fieldSymbol) && Equals(fs.CorrespondingTupleField(), fieldSymbol));
 
             return SyntaxFactory.IdentifierName(fieldNameSymbol.Name).WithTriviaFrom(fieldName);
         }

StyleCop.Analyzers/StyleCop.Analyzers.Internal.ruleset

@@ -10,7 +10,9 @@
     <Rule Id="xUnit1004" Action="Info" />
   </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.Analyzers" RuleNamespace="Microsoft.CodeAnalysis.Analyzers">
-    <Rule Id="RS1001" Action="None" />
-    <Rule Id="RS1004" Action="None" />
+    <Rule Id="RS1001" Action="None" /> <!-- Missing diagnostic analyzer attribute -->
+    <Rule Id="RS1004" Action="None" /> <!-- Recommend adding language support to diagnostic analyzer -->
+    <Rule Id="RS1029" Action="None" /> <!-- Do not use reserved diagnostic IDs -->
+    <Rule Id="RS2008" Action="None" /> <!-- Enable analyzer release tracking -->
   </Rules>
 </RuleSet>

StyleCop.Analyzers/StyleCop.Analyzers.Test/AnalyzerExtensionsTests.cs

@@ -69,6 +69,9 @@ public AnalyzerExtensionsTests AnalyzerExtensionsTests
 
             public override void Initialize(AnalysisContext context)
             {
+                context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+                context.EnableConcurrentExecution();
+
                 context.RegisterCompilationStartAction(
                     compilationStartContext =>
                     {

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1612UnitTests.cs

@@ -132,7 +132,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = new[]
             {
@@ -215,7 +215,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = new[]
             {
@@ -248,7 +248,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = diagnostic.WithLocation(13, 22).WithArguments("bar", 2);
 
@@ -353,7 +353,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = new[]
             {
@@ -400,7 +400,7 @@ public class ClassName
 }";
 
             var diagnostic = Diagnostic()
-                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}.");
+                .WithMessageFormat("The parameter documentation for '{0}' should be at position {1}");
 
             var expected = diagnostic.WithLocation(8, 22).WithArguments("bar", 2);
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/Helpers/ExclusionTestAnalyzer.cs

@@ -20,7 +20,7 @@ internal class ExclusionTestAnalyzer : DiagnosticAnalyzer
         internal const string DiagnosticId = "SA9999";
         private const string Title = "Exclusion test";
         private const string MessageFormat = "Exclusion test";
-        private const string Description = "Exclusion test";
+        private const string Description = "Exclusion test.";
         private const string HelpLink = "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA9999.md";
 
         private static readonly DiagnosticDescriptor Descriptor =