Use lists for analyzer test transforms

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1005UnitTests.cs

@@ -268,21 +268,18 @@ public class Bar
             await VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
 
             // Verify that this works if the project was configured to treat documentation comments as regular comments
-            var test = new CSharpTest
+            await new CSharpTest
             {
                 TestCode = testCode,
-            };
-
-            var baseSolutionTransform = test.SolutionTransform;
-            test.SolutionTransform = (solution, projectId) =>
-            {
-                solution = baseSolutionTransform(solution, projectId);
-                var project = solution.GetProject(projectId);
-
-                return solution.WithProjectParseOptions(projectId, project.ParseOptions.WithDocumentationMode(DocumentationMode.None));
-            };
-
-            await test.RunAsync(CancellationToken.None).ConfigureAwait(false);
+                SolutionTransforms =
+                {
+                    (solution, projectId) =>
+                    {
+                        var project = solution.GetProject(projectId);
+                        return solution.WithProjectParseOptions(projectId, project.ParseOptions.WithDocumentationMode(DocumentationMode.None));
+                    },
+                },
+            }.RunAsync(CancellationToken.None).ConfigureAwait(false);
         }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test/Verifiers/GenericAnalyzerTest.cs

@@ -92,9 +92,9 @@ public string FixedCode
 
         public int NumberOfFixAllIterations { get; set; } = 1;
 
-        public Func<OptionSet, OptionSet> OptionsTransform { get; set; } = options => options;
+        public List<Func<OptionSet, OptionSet>> OptionsTransforms { get; } = new List<Func<OptionSet, OptionSet>>();
 
-        public Func<Solution, ProjectId, Solution> SolutionTransform { get; set; } = (solution, _) => solution;
+        public List<Func<Solution, ProjectId, Solution>> SolutionTransforms { get; } = new List<Func<Solution, ProjectId, Solution>>();
 
         public async Task RunAsync(CancellationToken cancellationToken)
         {
@@ -435,12 +435,20 @@ protected virtual Solution CreateSolution(ProjectId projectId, string language)
                 solution = solution.AddMetadataReference(projectId, MetadataReferences.SystemValueTupleReference);
             }
 
-            solution.Workspace.Options = this.OptionsTransform(solution.Workspace.Options);
+            foreach (var transform in this.OptionsTransforms)
+            {
+                solution.Workspace.Options = transform(solution.Workspace.Options);
+            }
 
             ParseOptions parseOptions = solution.GetProject(projectId).ParseOptions;
             solution = solution.WithProjectParseOptions(projectId, parseOptions.WithDocumentationMode(DocumentationMode.Diagnose));
 
-            return this.SolutionTransform(solution, projectId);
+            foreach (var transform in this.SolutionTransforms)
+            {
+                solution = transform(solution, projectId);
+            }
+
+            return solution;
         }
 
         /// <summary>

StyleCop.Analyzers/StyleCop.Analyzers.Test/Verifiers/StyleCopDiagnosticVerifier`1.cs

@@ -51,13 +51,13 @@ internal class CSharpTest : DiagnosticVerifier<TAnalyzer>.CSharpTest
 
             public CSharpTest()
             {
-                this.OptionsTransform = options =>
+                this.OptionsTransforms.Add(options =>
                     options
                     .WithChangedOption(FormattingOptions.IndentationSize, this.Language, this.IndentationSize)
                     .WithChangedOption(FormattingOptions.TabSize, this.Language, this.TabSize)
-                    .WithChangedOption(FormattingOptions.UseTabs, this.Language, this.UseTabs);
+                    .WithChangedOption(FormattingOptions.UseTabs, this.Language, this.UseTabs));
 
-                this.SolutionTransform = (solution, projectId) =>
+                this.SolutionTransforms.Add((solution, projectId) =>
                 {
                     var settings = this.Settings;
 
@@ -101,7 +101,7 @@ public CSharpTest()
                     }
 
                     return solution;
-                };
+                });
             }
 
             /// <summary>