Skip to content

Commit de3dbee

Browse files
vweijstersvweijsters
committed
Fix IDE0060 Remove unused parameter
1 parent fb9a351 commit de3dbee

23 files changed

Lines changed: 112 additions & 63 deletions

File tree

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/InheritdocCodeFixProvider.cs‎

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -90,36 +90,36 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
9090
context.RegisterCodeFix(
9191
CodeAction.Create(
9292
DocumentationResources.InheritdocCodeFix,
93-
cancellationToken => GetTransformedDocumentAsync(context.Document, diagnostic, root, identifierToken, cancellationToken),
93+
cancellationToken => GetTransformedDocumentAsync(context.Document, root, identifierToken, cancellationToken),
9494
nameof(InheritdocCodeFixProvider)),
9595
diagnostic);
9696
}
9797
}
9898

99-
private static async Task<Document> GetTransformedDocumentAsync(Document document, Diagnostic diagnostic, SyntaxNode root, SyntaxToken identifierToken, CancellationToken cancellationToken)
99+
private static async Task<Document> GetTransformedDocumentAsync(Document document, SyntaxNode root, SyntaxToken identifierToken, CancellationToken cancellationToken)
100100
{
101101
SemanticModel semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false);
102102
switch (identifierToken.Parent.Kind())
103103
{
104104
case SyntaxKind.PropertyDeclaration:
105105
case SyntaxKind.EventDeclaration:
106-
return GetTransformedDocumentForBasePropertyDeclaration(document, diagnostic, root, semanticModel, (BasePropertyDeclarationSyntax)identifierToken.Parent, cancellationToken);
106+
return GetTransformedDocumentForBasePropertyDeclaration(document, root, semanticModel, (BasePropertyDeclarationSyntax)identifierToken.Parent, cancellationToken);
107107

108108
case SyntaxKind.MethodDeclaration:
109-
return GetTransformedDocumentForMethodDeclaration(document, diagnostic, root, semanticModel, (MethodDeclarationSyntax)identifierToken.Parent, cancellationToken);
109+
return GetTransformedDocumentForMethodDeclaration(document, root, semanticModel, (MethodDeclarationSyntax)identifierToken.Parent, cancellationToken);
110110

111111
case SyntaxKind.VariableDeclarator:
112-
return GetTransformedDocumentForEventFieldDeclaration(document, diagnostic, root, semanticModel, (EventFieldDeclarationSyntax)identifierToken.Parent.Parent.Parent, cancellationToken);
112+
return GetTransformedDocumentForEventFieldDeclaration(document, root, semanticModel, (EventFieldDeclarationSyntax)identifierToken.Parent.Parent.Parent, cancellationToken);
113113

114114
case SyntaxKind.IndexerDeclaration:
115-
return GetTransformedDocumentForIndexerDeclaration(document, diagnostic, root, semanticModel, (IndexerDeclarationSyntax)identifierToken.Parent, cancellationToken);
115+
return GetTransformedDocumentForIndexerDeclaration(document, root, semanticModel, (IndexerDeclarationSyntax)identifierToken.Parent, cancellationToken);
116116

117117
default:
118118
return document;
119119
}
120120
}
121121

122-
private static Document GetTransformedDocumentForBasePropertyDeclaration(Document document, Diagnostic diagnostic, SyntaxNode root, SemanticModel semanticModel, BasePropertyDeclarationSyntax basePropertyDeclaration, CancellationToken cancellationToken)
122+
private static Document GetTransformedDocumentForBasePropertyDeclaration(Document document, SyntaxNode root, SemanticModel semanticModel, BasePropertyDeclarationSyntax basePropertyDeclaration, CancellationToken cancellationToken)
123123
{
124124
if (basePropertyDeclaration.ExplicitInterfaceSpecifier == null && !basePropertyDeclaration.Modifiers.Any(SyntaxKind.OverrideKeyword))
125125
{
@@ -130,10 +130,10 @@ private static Document GetTransformedDocumentForBasePropertyDeclaration(Documen
130130
}
131131
}
132132

133-
return InsertInheritdocComment(document, diagnostic, root, basePropertyDeclaration, cancellationToken);
133+
return InsertInheritdocComment(document, root, basePropertyDeclaration, cancellationToken);
134134
}
135135

136-
private static Document GetTransformedDocumentForMethodDeclaration(Document document, Diagnostic diagnostic, SyntaxNode root, SemanticModel semanticModel, MethodDeclarationSyntax methodDeclaration, CancellationToken cancellationToken)
136+
private static Document GetTransformedDocumentForMethodDeclaration(Document document, SyntaxNode root, SemanticModel semanticModel, MethodDeclarationSyntax methodDeclaration, CancellationToken cancellationToken)
137137
{
138138
if (methodDeclaration.ExplicitInterfaceSpecifier == null && !methodDeclaration.Modifiers.Any(SyntaxKind.OverrideKeyword))
139139
{
@@ -144,10 +144,10 @@ private static Document GetTransformedDocumentForMethodDeclaration(Document docu
144144
}
145145
}
146146

147-
return InsertInheritdocComment(document, diagnostic, root, methodDeclaration, cancellationToken);
147+
return InsertInheritdocComment(document, root, methodDeclaration, cancellationToken);
148148
}
149149

150-
private static Document GetTransformedDocumentForEventFieldDeclaration(Document document, Diagnostic diagnostic, SyntaxNode root, SemanticModel semanticModel, EventFieldDeclarationSyntax eventFieldDeclaration, CancellationToken cancellationToken)
150+
private static Document GetTransformedDocumentForEventFieldDeclaration(Document document, SyntaxNode root, SemanticModel semanticModel, EventFieldDeclarationSyntax eventFieldDeclaration, CancellationToken cancellationToken)
151151
{
152152
if (!eventFieldDeclaration.Modifiers.Any(SyntaxKind.OverrideKeyword))
153153
{
@@ -164,10 +164,10 @@ private static Document GetTransformedDocumentForEventFieldDeclaration(Document
164164
}
165165
}
166166

167-
return InsertInheritdocComment(document, diagnostic, root, eventFieldDeclaration, cancellationToken);
167+
return InsertInheritdocComment(document, root, eventFieldDeclaration, cancellationToken);
168168
}
169169

170-
private static Document GetTransformedDocumentForIndexerDeclaration(Document document, Diagnostic diagnostic, SyntaxNode root, SemanticModel semanticModel, IndexerDeclarationSyntax indexerDeclaration, CancellationToken cancellationToken)
170+
private static Document GetTransformedDocumentForIndexerDeclaration(Document document, SyntaxNode root, SemanticModel semanticModel, IndexerDeclarationSyntax indexerDeclaration, CancellationToken cancellationToken)
171171
{
172172
if (indexerDeclaration.ExplicitInterfaceSpecifier == null && !indexerDeclaration.Modifiers.Any(SyntaxKind.OverrideKeyword))
173173
{
@@ -178,11 +178,14 @@ private static Document GetTransformedDocumentForIndexerDeclaration(Document doc
178178
}
179179
}
180180

181-
return InsertInheritdocComment(document, diagnostic, root, indexerDeclaration, cancellationToken);
181+
return InsertInheritdocComment(document, root, indexerDeclaration, cancellationToken);
182182
}
183183

184-
private static Document InsertInheritdocComment(Document document, Diagnostic diagnostic, SyntaxNode root, SyntaxNode syntaxNode, CancellationToken cancellationToken)
184+
private static Document InsertInheritdocComment(Document document, SyntaxNode root, SyntaxNode syntaxNode, CancellationToken cancellationToken)
185185
{
186+
// Currently unused
187+
_ = cancellationToken;
188+
186189
SyntaxTriviaList leadingTrivia = syntaxNode.GetLeadingTrivia();
187190
int insertionIndex = leadingTrivia.Count;
188191
while (insertionIndex > 0 && !leadingTrivia[insertionIndex - 1].HasBuiltinEndLine())

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1600CodeFixProvider.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
5959
context.RegisterCodeFix(
6060
CodeAction.Create(
6161
DocumentationResources.ConstructorDocumentationCodeFix,
62-
cancellationToken => GetConstructorOrDestructorDocumentationTransformedDocumentAsync(context.Document, diagnostic, root, (BaseMethodDeclarationSyntax)identifierToken.Parent, cancellationToken),
62+
cancellationToken => GetConstructorOrDestructorDocumentationTransformedDocumentAsync(context.Document, root, (BaseMethodDeclarationSyntax)identifierToken.Parent, cancellationToken),
6363
nameof(SA1600CodeFixProvider)),
6464
diagnostic);
6565
break;
@@ -72,7 +72,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
7272
context.RegisterCodeFix(
7373
CodeAction.Create(
7474
DocumentationResources.MethodDocumentationCodeFix,
75-
cancellationToken => GetMethodDocumentationTransformedDocumentAsync(context.Document, diagnostic, root, semanticModel, (MethodDeclarationSyntax)identifierToken.Parent, cancellationToken),
75+
cancellationToken => GetMethodDocumentationTransformedDocumentAsync(context.Document, root, semanticModel, (MethodDeclarationSyntax)identifierToken.Parent, cancellationToken),
7676
nameof(SA1600CodeFixProvider)),
7777
diagnostic);
7878
}
@@ -98,7 +98,7 @@ private static bool IsCoveredByInheritDoc(SemanticModel semanticModel, MethodDec
9898
return (declaredSymbol != null) && NamedTypeHelpers.IsImplementingAnInterfaceMember(declaredSymbol);
9999
}
100100

101-
private static Task<Document> GetConstructorOrDestructorDocumentationTransformedDocumentAsync(Document document, Diagnostic diagnostic, SyntaxNode root, BaseMethodDeclarationSyntax declaration, CancellationToken cancellationToken)
101+
private static Task<Document> GetConstructorOrDestructorDocumentationTransformedDocumentAsync(Document document, SyntaxNode root, BaseMethodDeclarationSyntax declaration, CancellationToken cancellationToken)
102102
{
103103
SyntaxTriviaList leadingTrivia = declaration.GetLeadingTrivia();
104104
int insertionIndex = GetInsertionIndex(ref leadingTrivia);
@@ -136,7 +136,7 @@ private static Task<Document> GetConstructorOrDestructorDocumentationTransformed
136136
return Task.FromResult(document.WithSyntaxRoot(root.ReplaceNode(declaration, newElement)));
137137
}
138138

139-
private static Task<Document> GetMethodDocumentationTransformedDocumentAsync(Document document, Diagnostic diagnostic, SyntaxNode root, SemanticModel semanticModel, MethodDeclarationSyntax methodDeclaration, CancellationToken cancellationToken)
139+
private static Task<Document> GetMethodDocumentationTransformedDocumentAsync(Document document, SyntaxNode root, SemanticModel semanticModel, MethodDeclarationSyntax methodDeclaration, CancellationToken cancellationToken)
140140
{
141141
SyntaxTriviaList leadingTrivia = methodDeclaration.GetLeadingTrivia();
142142
int insertionIndex = GetInsertionIndex(ref leadingTrivia);

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1642SA1643CodeFixProvider.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ private static Task<Document> GetTransformedDocumentAsync(Document document, Syn
147147

148148
string trailingString = string.Empty;
149149

150-
var newContent = RemoveMalformattedStandardText(node.Content, typeDeclaration.Identifier, standardText[0], standardText[1], ref trailingString);
150+
var newContent = RemoveMalformattedStandardText(node.Content, standardText[0], standardText[1], ref trailingString);
151151

152152
if (newContent.Count == 1 && newContent[0] is XmlTextSyntax xmlText)
153153
{
@@ -192,7 +192,7 @@ private static Task<Document> GetTransformedDocumentAsync(Document document, Syn
192192
return Task.FromResult(newDocument);
193193
}
194194

195-
private static SyntaxList<XmlNodeSyntax> RemoveMalformattedStandardText(SyntaxList<XmlNodeSyntax> content, SyntaxToken identifier, string preText, string postText, ref string trailingString)
195+
private static SyntaxList<XmlNodeSyntax> RemoveMalformattedStandardText(SyntaxList<XmlNodeSyntax> content, string preText, string postText, ref string trailingString)
196196
{
197197
var regex = new Regex(@"^\s*" + Regex.Escape(preText) + "[^ ]+" + Regex.Escape(postText));
198198
var item = content.OfType<XmlTextSyntax>().FirstOrDefault();

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/LayoutRules/SA1500CodeFixProvider.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
5757

5858
var settings = SettingsHelper.GetStyleCopSettings(document.Project.AnalyzerOptions, cancellationToken);
5959
var braceToken = syntaxRoot.FindToken(diagnostic.Location.SourceSpan.Start);
60-
var tokenReplacements = GenerateBraceFixes(document, settings.Indentation, ImmutableArray.Create(braceToken));
60+
var tokenReplacements = GenerateBraceFixes(settings.Indentation, ImmutableArray.Create(braceToken));
6161

6262
var newSyntaxRoot = syntaxRoot.ReplaceTokens(tokenReplacements.Keys, (originalToken, rewrittenToken) => tokenReplacements[originalToken]);
6363
return document.WithSyntaxRoot(newSyntaxRoot);
6464
}
6565

66-
private static Dictionary<SyntaxToken, SyntaxToken> GenerateBraceFixes(Document document, IndentationSettings indentationSettings, ImmutableArray<SyntaxToken> braceTokens)
66+
private static Dictionary<SyntaxToken, SyntaxToken> GenerateBraceFixes(IndentationSettings indentationSettings, ImmutableArray<SyntaxToken> braceTokens)
6767
{
6868
var tokenReplacements = new Dictionary<SyntaxToken, SyntaxToken>();
6969

@@ -284,7 +284,7 @@ protected override async Task<SyntaxNode> FixAllInDocumentAsync(FixAllContext fi
284284

285285
var settings = SettingsHelper.GetStyleCopSettings(document.Project.AnalyzerOptions, fixAllContext.CancellationToken);
286286

287-
var tokenReplacements = GenerateBraceFixes(document, settings.Indentation, tokens);
287+
var tokenReplacements = GenerateBraceFixes(settings.Indentation, tokens);
288288

289289
return syntaxRoot.ReplaceTokens(tokenReplacements.Keys, (originalToken, rewrittenToken) => tokenReplacements[originalToken]);
290290
}

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/LayoutRules/SA1503CodeFixProvider.cs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
6464

6565
private static Task<Document> GetTransformedDocumentAsync(Document document, SyntaxNode root, StatementSyntax node, CancellationToken cancellationToken)
6666
{
67+
// Currently unused
68+
_ = cancellationToken;
69+
6770
var newSyntaxRoot = root.ReplaceNode(node, SyntaxFactory.Block(node));
6871
return Task.FromResult(document.WithSyntaxRoot(newSyntaxRoot));
6972
}

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/LayoutRules/SA1516CodeFixProvider.cs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
7878

7979
private static Task<Document> GetTransformedDocumentAsync(Document document, SyntaxNode syntaxRoot, Diagnostic diagnostic, bool insertBlankLine, CancellationToken cancellationToken)
8080
{
81+
// Currently unused
82+
_ = cancellationToken;
83+
8184
var node = syntaxRoot.FindNode(diagnostic.Location.SourceSpan, getInnermostNodeForTie: true);
8285
node = GetRelevantNode(node);
8386

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/MaintainabilityRules/SA1407SA1408FixAllProvider.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ protected override async Task<SyntaxNode> FixAllInDocumentAsync(FixAllContext fi
3737
nodes.Add(node);
3838
}
3939

40-
return root.ReplaceNodes(nodes, (originalNode, rewrittenNode) => AddParentheses(originalNode, rewrittenNode));
40+
return root.ReplaceNodes(nodes, (originalNode, rewrittenNode) => AddParentheses(rewrittenNode));
4141
}
4242

43-
private static SyntaxNode AddParentheses(SyntaxNode originalNode, SyntaxNode rewrittenNode)
43+
private static SyntaxNode AddParentheses(SyntaxNode node)
4444
{
45-
if (!(rewrittenNode is BinaryExpressionSyntax syntax))
45+
if (!(node is BinaryExpressionSyntax syntax))
4646
{
47-
return rewrittenNode;
47+
return node;
4848
}
4949

5050
BinaryExpressionSyntax trimmedSyntax = syntax.WithoutTrivia();

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.SourceMap.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,27 +146,27 @@ private static void BuildDirectiveTriviaMaps(CompilationUnitSyntax compilationUn
146146
switch (directiveTrivia.Kind())
147147
{
148148
case SyntaxKind.IfDirectiveTrivia:
149-
AddNewDirectiveTriviaSpan(conditionalBuilder, conditionalStack, directiveTrivia);
149+
AddNewDirectiveTriviaSpan(conditionalStack, directiveTrivia);
150150
break;
151151

152152
case SyntaxKind.ElifDirectiveTrivia:
153153
case SyntaxKind.ElseDirectiveTrivia:
154154
var previousSpan = conditionalStack.Pop();
155155
previousSpan.SetEnd(directiveTrivia.FullSpan.Start);
156156

157-
AddNewDirectiveTriviaSpan(conditionalBuilder, conditionalStack, directiveTrivia);
157+
AddNewDirectiveTriviaSpan(conditionalStack, directiveTrivia);
158158
break;
159159

160160
case SyntaxKind.EndIfDirectiveTrivia:
161-
CloseDirectiveTriviaSpan(conditionalBuilder, conditionalStack, directiveTrivia);
161+
CloseDirectiveTriviaSpan(conditionalStack, directiveTrivia);
162162
break;
163163

164164
case SyntaxKind.RegionDirectiveTrivia:
165-
AddNewDirectiveTriviaSpan(regionBuilder, regionStack, directiveTrivia);
165+
AddNewDirectiveTriviaSpan(regionStack, directiveTrivia);
166166
break;
167167

168168
case SyntaxKind.EndRegionDirectiveTrivia:
169-
CloseDirectiveTriviaSpan(regionBuilder, regionStack, directiveTrivia);
169+
CloseDirectiveTriviaSpan(regionStack, directiveTrivia);
170170
break;
171171

172172
case SyntaxKind.PragmaWarningDirectiveTrivia:
@@ -192,14 +192,14 @@ private static TreeTextSpan.Builder SetupBuilder(CompilationUnitSyntax compilati
192192
return rootBuilder;
193193
}
194194

195-
private static void AddNewDirectiveTriviaSpan(TreeTextSpan.Builder spanBuilder, Stack<TreeTextSpan.Builder> spanStack, DirectiveTriviaSyntax directiveTrivia)
195+
private static void AddNewDirectiveTriviaSpan(Stack<TreeTextSpan.Builder> spanStack, DirectiveTriviaSyntax directiveTrivia)
196196
{
197197
var parent = spanStack.Peek();
198198
var newDirectiveSpan = parent.AddChild(directiveTrivia.FullSpan.Start);
199199
spanStack.Push(newDirectiveSpan);
200200
}
201201

202-
private static void CloseDirectiveTriviaSpan(TreeTextSpan.Builder spanBuilder, Stack<TreeTextSpan.Builder> spanStack, DirectiveTriviaSyntax directiveTrivia)
202+
private static void CloseDirectiveTriviaSpan(Stack<TreeTextSpan.Builder> spanStack, DirectiveTriviaSyntax directiveTrivia)
203203
{
204204
var previousSpan = spanStack.Pop();
205205
previousSpan.SetEnd(directiveTrivia.FullSpan.End);

‎StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Settings/SettingsFileCodeFixProvider.cs‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
7979
context.RegisterCodeFix(
8080
CodeAction.Create(
8181
SettingsResources.SettingsFileCodeFix,
82-
cancellationToken => GetTransformedSolutionAsync(context.Document, diagnostic, cancellationToken),
82+
cancellationToken => GetTransformedSolutionAsync(context.Document, cancellationToken),
8383
nameof(SettingsFileCodeFixProvider)),
8484
diagnostic);
8585
}
@@ -94,8 +94,11 @@ public override FixAllProvider GetFixAllProvider()
9494
return null;
9595
}
9696

97-
private static Task<Solution> GetTransformedSolutionAsync(Document document, Diagnostic diagnostic, CancellationToken cancellationToken)
97+
private static Task<Solution> GetTransformedSolutionAsync(Document document, CancellationToken cancellationToken)
9898
{
99+
// Currently unused
100+
_ = cancellationToken;
101+
99102
var project = document.Project;
100103
var solution = project.Solution;
101104

0 commit comments

Comments
 (0)