Fix RS1024 (Compare symbols correctly)

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1141CodeFixProvider.cs

@@ -132,7 +132,7 @@ private static SyntaxNode TransformArgumentListToTuple(SemanticModel semanticMod
                 var argument = arguments[i];
 
                 var argumentTypeInfo = semanticModel.GetTypeInfo(argument.Expression);
-                if (argumentTypeInfo.Type != argumentTypeInfo.ConvertedType)
+                if (!Equals(argumentTypeInfo.Type, argumentTypeInfo.ConvertedType))
                 {
                     var expectedType = SyntaxFactory.ParseTypeName(argumentTypeInfo.ConvertedType.ToDisplayString());
                     argument = argument.WithExpression(SyntaxFactory.CastExpression(expectedType, argument.Expression));

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1142CodeFixProvider.cs

@@ -59,7 +59,7 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
         private static SyntaxNode GetReplacementNode(SemanticModel semanticModel, SyntaxNode fieldName)
         {
             var fieldSymbol = (IFieldSymbol)semanticModel.GetSymbolInfo(fieldName.Parent).Symbol;
-            var fieldNameSymbol = fieldSymbol.ContainingType.GetMembers().OfType<IFieldSymbol>().Single(fs => (fs != fieldSymbol) && (fs.CorrespondingTupleField() == fieldSymbol));
+            var fieldNameSymbol = fieldSymbol.ContainingType.GetMembers().OfType<IFieldSymbol>().Single(fs => !Equals(fs, fieldSymbol) && Equals(fs.CorrespondingTupleField(), fieldSymbol));
 
             return SyntaxFactory.IdentifierName(fieldNameSymbol.Name).WithTriviaFrom(fieldName);
         }

StyleCop.Analyzers/StyleCop.Analyzers/Helpers/SymbolNameHelpers.cs

@@ -196,7 +196,7 @@ private static bool AppendTupleType(StringBuilder builder, INamedTypeSymbol name
                     }
 
                     AppendQualifiedSymbolName(builder, field.Type, fieldType.Type);
-                    if (field != field.CorrespondingTupleField())
+                    if (!Equals(field, field.CorrespondingTupleField()))
                     {
                         builder.Append(" ").Append(field.Name);
                     }

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1142ReferToTupleElementsByName.cs

@@ -70,13 +70,13 @@ private static bool CheckFieldName(IFieldSymbol fieldSymbol)
             }
 
             // check if this already is a proper tuple field name
-            if (fieldSymbol.CorrespondingTupleField() != fieldSymbol)
+            if (!Equals(fieldSymbol.CorrespondingTupleField(), fieldSymbol))
             {
                 return false;
             }
 
             // check if there is a tuple field name declared.
-            return fieldSymbol.ContainingType.GetMembers().OfType<IFieldSymbol>().Count(fs => fs.CorrespondingTupleField() == fieldSymbol) > 1;
+            return fieldSymbol.ContainingType.GetMembers().OfType<IFieldSymbol>().Count(fs => Equals(fs.CorrespondingTupleField(), fieldSymbol)) > 1;
         }
     }
 }