Remove unreachable test code

sharwell · sharwell · commit f78d06ed98c4 · 2017-06-20T12:17:45.000-05:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1605UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1605UnitTests.cs
@@ -347,7 +347,8 @@ protected override Project ApplyCompilationOptions(Project project)
 
         protected override string GetSettings()
         {
-            return this.currentTestSettings ?? base.GetSettings();
+            Assert.NotNull(this.currentTestSettings);
+            return this.currentTestSettings;
         }
 
         protected override IEnumerable<DiagnosticAnalyzer> GetCSharpDiagnosticAnalyzers()

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,8 @@ protected override Project ApplyCompilationOptions(Project project)`
`347`	`347`
`348`	`348`	`protected override string GetSettings()`
`349`	`349`	`{`
`350`		`- return this.currentTestSettings ?? base.GetSettings();`
	`350`	`+ Assert.NotNull(this.currentTestSettings);`
	`351`	`+ return this.currentTestSettings;`
`351`	`352`	`}`
`352`	`353`
`353`	`354`	`protected override IEnumerable<DiagnosticAnalyzer> GetCSharpDiagnosticAnalyzers()`