Repository navigation
Configurable bell ping for territory and in-war start warnings - #41
Merged
Merged
Conversation
Good627
changed the title
Good627
force-pushed
the
FINALV2WARSTARTPING
branch
from
October 22, 2026 13:57
22fd573 to
9ba5aae
Compare
Good627
force-pushed
the
FINALV2WARSTARTPING
branch
from
October 22, 2026 17:43
9ba5aae to
e86e55d
Compare
# Conflicts: # src/tel/eden/mod/EdenModClient.java
The territory bell no longer waits for the "will start in 30 seconds" chat line and runs its own countdown. It now rings when an attack timer (sidebar or chat-filled) is at the chosen number of seconds or less while you stand in that territory, the same check that turns the timer row pink. Each attack rings once, walking in late still rings, and a timer briefly dropping off the sidebar doesn't ring it again. The setting goes up to 120s, and the queued-only toggle is gone since standing in the territory replaces it. The check rides on the attack timer's existing per-tick scan and only looks up where you stand once some timer is due. The in-war 25s battle bell is unchanged.
…ines The bell now rings as soon as the in-war countdown starts (the 25s line) instead of after a chosen delay. If lag drops that line, the next countdown line rings instead, down to the final "5 seconds..." ones, and it still rings only once per war.
Match the final "5 seconds..." lines only when the line is just the countdown (or follows a font tag), so other countdowns like "teleported in 5 seconds..." can't ring the war bell outside a war.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bell pings for guild wars, both in
/eden config-> War and off by default.warBattleStartBell, on/off): rings when the in-war battle countdown starts ("The war battle will start in 25 seconds."). If lag drops that line, the next countdown line rings instead, down to the final "5 seconds..." lines. Rings once per war; cleared when the battle begins, the attack is cancelled, or on a world change or disconnect.warAttackTimerBellSeconds, Off to 120s in 5s steps): rings once when an attack timer (sidebar or chat-filled) for the territory you're standing in (the pink row) is at that many seconds or less. Walking in late still rings; a timer briefly dropping off the sidebar doesn't ring it again; a new attack on the same territory does.Details
AttackTimerMenu.onTick's existing per-tick scan and only looks up where you stand once some timer is due, so it costs nothing measurable per frame.forgetTerritory) and on a full reset.WarStartPingTrackerTestcover once-per-war/attack ringing, the missed-line fallback, standing-in checks, chat filtering and the lazy territory lookup.