Deprecate coupling to Jackson-2 API#325
Open
randallwhitman wants to merge 3 commits into
Open
Conversation
Member
|
@randallwhitman It looks good. Would it also make sense to add a comment in the code what to do on deprecation warning? |
stolstov
approved these changes
Jun 26, 2026
Contributor
Author
On those methods that have existing javadoc, i included the type-name of the argument that should be used instead. Let me know what would be a better message. (or go ahead update it as you see fit) update: i commented updated wording - apply it if you like. |
randallwhitman
commented
Jun 26, 2026
|
|
||
|
|
||
| /** | ||
| * @deprecated String |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| * @deprecated String | |
| * @deprecated Use jsonToGeometry(String) |
randallwhitman
commented
Jun 26, 2026
| } | ||
|
|
||
| /** | ||
| * @deprecated String |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| * @deprecated String | |
| * @deprecated Use fromJson(String) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for potential upgrade to Jackson-3.
for #324 (comment)