Skip to content

[Payment due @ZhenjaHorbach] [No QA] Override tinypool to 2.1.2 to patch Dependabot alerts - #103756

Merged
JS00001 merged 2 commits into
mainfrom
claude-bumpTinypool
Oct 13, 2026
Merged

[Payment due @ZhenjaHorbach] [No QA] Override tinypool to 2.1.2 to patch Dependabot alerts#103756
JS00001 merged 2 commits into
mainfrom
claude-bumpTinypool

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Overrides tinypool 2.1.0 → 2.1.2 to patch two critical prototype-pollution → RCE advisories (GHSA-5gmw-xhrv-c9v3, GHSA-85c8-ppgw-ccpr).

Usage: Dev-only, transitive. oxfmt (our formatter) pins tinypool@2.1.0 to run formatting in worker threads. It runs via npm run fmt, the lefthook pre-commit hook, and the oxfmt CI workflow. Not shipped in the app bundle.

Why an override: oxfmt pins tinypool exactly, and the first oxfmt release with a patched tinypool is 0.67.0 (12 minors ahead), which risks formatting churn. 2.1.2 is a patch release containing only the two security fixes.

Change Log

Full: tinylibs/tinypool@v2.1.0...v2.1.2

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/690938
PROPOSAL:

Tests

  1. npm ci → succeeds.
  2. npm ls tinypool → tinypool@2.1.2 overridden under oxfmt.
  3. npm run fmt → completes, no unexpected diffs.
  4. Edit and stage a .ts file with bad formatting, commit → lefthook oxfmt hook reformats it.
  5. oxfmt CI check passes on this PR.
  • Verify that no errors appear in the JS console

Offline tests

N/A — dev tooling only.

QA Steps

None — dev-only dependency, no app changes. Title includes "[No QA]".

  • Verify that no errors appear in the JS console

PR Author Checklist

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot
MelvinBot requested a review from a team as a code owner October 12, 2026 12:24
@melvin-bot
melvin-bot Bot requested a review from ZhenjaHorbach October 12, 2026 12:24
@melvin-bot

melvin-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 12, 2026 12:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T12:27:23.637244Z 719260a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 8 files with indirect coverage changes

@ZhenjaHorbach

ZhenjaHorbach commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-10-13.at.14.21.04.mov
Android: mWeb Chrome
Screen.Recording.2026-10-13.at.14.21.04.mov
iOS: HybridApp
Screen.Recording.2026-10-13.at.14.21.04.mov
iOS: mWeb Safari
Screen.Recording.2026-10-13.at.14.21.04.mov
MacOS: Chrome / Safari
Screen.Recording.2026-10-13.at.14.21.04.mov

JS00001
JS00001 previously approved these changes Oct 13, 2026
View reviewed changes
@ZhenjaHorbach

ZhenjaHorbach commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot
Fix conflicts

@MelvinBot

MelvinBot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

The conflict is small: one line in the overrides block of package.json.

[No QA] Override @simple-git/argv-parser to 2.0.1 (GHSA-v5rq-49vh-5v5c) added "@simple-git/argv-parser": "2.0.1" on the same line where this PR adds "tinypool": "2.1.2". To fix it, keep both entries. package-lock.json merges cleanly.

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. To have me implement this, the PR assignee or author should reply with a request tagging me.

view run

@ZhenjaHorbach

ZhenjaHorbach commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot
I was assigned to this PR
Fix conflicts

@MelvinBot

MelvinBot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I merged main and fixed the conflict.

The only conflict was in the overrides block of package.json. I kept both "tinypool": "2.1.2" and "@simple-git/argv-parser": "2.0.1", which came from [No QA] Override @simple-git/argv-parser to 2.0.1 (GHSA-v5rq-49vh-5v5c). package-lock.json merged on its own. The PR diff against main is unchanged: the same 2 files, with 4 lines added and 3 removed.

@melvin-bot
melvin-bot Bot requested a review from JS00001 October 13, 2026 12:28
@melvin-bot melvin-bot Bot changed the title [No QA] Override tinypool to 2.1.2 to patch Dependabot alerts [Payment due @ZhenjaHorbach] [No QA] Override tinypool to 2.1.2 to patch Dependabot alerts Oct 13, 2026
@melvin-bot

melvin-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/690938.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@JS00001
JS00001 merged commit fddcebf into main Oct 13, 2026
52 of 55 checks passed
@JS00001
JS00001 deleted the claude-bumpTinypool branch October 13, 2026 12:36
@github-actions

github-actions Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103756.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fddcebf-ffd7862-1cddd7f00ed7c219169b36206ea68c139f87725f/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fddcebf-ffd7862-29a2fa202a37e539532bc12d51fce35c208a9fe5/index.html
Android iOS
Web 🕸️
https://103756.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Oct 14, 2026
Closed
92 tasks done
@OSBotify

OSBotify commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.9-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.9-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot melvin-bot Bot mentioned this pull request Oct 15, 2026
Open
@melvin-bot

melvin-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #104115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inimaga inimaga inimaga approved these changes
@JS00001 JS00001 Awaiting requested review from JS00001
+1 more reviewer
@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MelvinBot MelvinBot

@JS00001 JS00001

@ZhenjaHorbach ZhenjaHorbach

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MelvinBot @ZhenjaHorbach @OSBotify @inimaga @JS00001