Skip to content

fix: add buffer-length check in cn10k_ml_model.c #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: add buffer-length check in cn10k_ml_model.c #1066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions dpdk/drivers/ml/cnxk/cn10k_ml_model.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,16 @@ cn10k_ml_model_metadata_check(uint8_t *buffer, uint64_t size)
return -EINVAL;
}

/* Validate total section sizes fit within the provided buffer */
if ((uint64_t)sizeof(struct cn10k_ml_model_metadata) +
metadata->init_model.file_size +
metadata->main_model.file_size +
metadata->finish_model.file_size +
metadata->weights_bias.file_size > size) {
plt_err("Invalid metadata, model section sizes exceed buffer size");
return -EINVAL;
}

if (metadata->weights_bias.relocatable != 1) {
plt_err("Model not supported, non-relocatable weights and bias");
return -ENOTSUP;
Expand Down