Repository navigation
fix: FoliaAsyncScheduler#schedule(Runnable, Duration) recursing into StackOverflowError - #205
Open
DragonL0508 wants to merge 1 commit into
Open
DragonL0508 wants to merge 1 commit into
DragonL0508 wants to merge 1 commit into
Conversation
…StackOverflowError FoliaAsyncScheduler overrides schedule(Runnable, long) to delegate to schedule(Runnable, Duration), but never overrides the latter. It falls back to the MCTickBasedScheduler default inherited through FoliaAbstractScheduler, which converts back to ticks and calls schedule(Runnable, long) again, so any delayed Runnable on the Folia async scheduler ends in a StackOverflowError. Route schedule(Runnable, Duration) to the Callable overload, which already talks to the Folia AsyncScheduler directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FoliaAsyncScheduleroverridesschedule(Runnable, long)to callschedule(Runnable, Duration), but never overrides the latter. It falls back to theMCTickBasedSchedulerdefault inherited throughFoliaAbstractScheduler, which converts back to ticks and callsschedule(Runnable, long)again, so any delayedRunnableon the Folia async scheduler ends in aStackOverflowError. (The region/global/entity schedulers don't override the tick overload, so they are not affected; Paper doesn't use this class.)schedule(Runnable, Duration)now goes through theCallableoverload, which already talks to the FoliaAsyncSchedulerdirectly.Tests:
FoliaAsyncSchedulerTestchecks that bothRunnableoverloads end up inschedule(Callable, Duration)with the right delay.🤖 Generated with Claude Code