Repository navigation
fix: YamlConfiguration(Path) sharing one non-thread-safe YamlProperties - #206
Open
DragonL0508 wants to merge 1 commit into
Open
DragonL0508 wants to merge 1 commit into
DragonL0508 wants to merge 1 commit into
Conversation
Every YamlConfiguration created with the single-argument constructor is bound to YamlProperties.DEFAULT, so all of them share the same snakeyaml Representer/Constructor. Those are not thread-safe: saving two such configurations from different threads at the same time (e.g. async saves, or Folia regions) randomly fails inside snakeyaml's Serializer with "Nodes must be provided", "anchor is not specified for alias" or ConcurrentModificationException. Give each configuration its own YamlProperties by default, and document that DEFAULT is shared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
YamlConfigurationcreated with the single-argument constructor is bound toYamlProperties.DEFAULT, so all of them share the same snakeyamlRepresenter/Constructor, which are not thread-safe. Saving two such configurations from different threads at the same time (async saves, Folia regions) randomly fails inside snakeyaml'sSerializerwithNodes must be provided,anchor is not specified for aliasorConcurrentModificationException.Each configuration now gets its own
YamlPropertiesby default, andDEFAULTis documented as shared.Tests:
YamlConfigurationConcurrencyTestsaves several configurations concurrently and loads them back.🤖 Generated with Claude Code