Repository navigation
fix: command permissions not visible to Bukkit and tab completion errors - #210
Open
DragonL0508 wants to merge 1 commit into
Open
DragonL0508 wants to merge 1 commit into
DragonL0508 wants to merge 1 commit into
Conversation
- BukkitCommandExecutor never told Bukkit about the command's permission, so every command was listed in every player's command tree: players without access still saw admin commands in the suggestions after "/". testPermissionSilent now asks BaseCommand#canAccess, the same check used before executing. - CommandMeta#completeCommand with a @wildcard last parameter looked up arguments.get(args.length - 1), which throws IndexOutOfBoundsException as soon as more words are typed than there are parameters. It now keeps completing with the wildcard argument. - Any exception thrown during tab completion was passed to onError, which sends "Internal Exception: ..." to the sender on every key press. It is now logged and the completion is empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BukkitCommandExecutornever told Bukkit about the command's permission, so every command was in every player's command tree: players without access still saw admin commands in the suggestions after/.testPermissionSilentnow asksBaseCommand#canAccess, the same check used before executing.@Wildcardcompletion:CommandMeta#completeCommandlooked uparguments.get(args.length - 1), which throwsIndexOutOfBoundsExceptionas soon as more words are typed than there are parameters. It now keeps completing with the wildcard argument.onError, which sendsInternal Exception: ...to the sender on every key press. It is now logged and the completion is empty.Tests:
BukkitCommandExecutorTest(permission followscanAccess, completion errors don't reachonError) andCommandMetaTest(wildcard completion past the parameter count).🤖 Generated with Claude Code