Optimize transformers#50
Open
danyadev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transformers from this mod take up roughly 25% (or 1500ms) of overall transformation time on GTNH client load
This PR doesn't eliminate the main bottleneck in GTNH, because there are two problematic parts: in the lib and in EndlessIDs, and without fixing both we won't gain any benefit. Though it should make any other modpack without EndlessIDs faster already
Code for the first commit was taken from GTNewHorizons/RetroFuturaBootstrap/pull/6
Code for the second commit was taken from GTNewHorizons/RetroFuturaBootstrap/pull/20
Here are the Before and After profiles, showing three transformers before (two of which were in the lib and were optimized in this pr) and only one transformer after (from EndlessIDs)