Add autocomplete hints for password inputs (#2661)

* Add autocomplete attributes to password inputs.

https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands

* Update composer.json to autoload tests.

* Add autocomplete hints to login form too

* checkstyle changes

Author: Willem Stuursma-Ruwen

Form/Type/ChangePasswordFormType.php

@@ -55,11 +55,19 @@ public function buildForm(FormBuilderInterface $builder, array $options)
                 new NotBlank(),
                 new UserPassword($constraintsOptions),
             ),
+            'attr' => array(
+                'autcomplete' => 'current-password',
+            ),
         ));
 
         $builder->add('plainPassword', RepeatedType::class, array(
             'type' => PasswordType::class,
-            'options' => array('translation_domain' => 'FOSUserBundle'),
+            'options' => array(
+                'translation_domain' => 'FOSUserBundle',
+                'attr' => array(
+                    'autcomplete' => 'new-password',
+                ),
+            ),
             'first_options' => array('label' => 'form.new_password'),
             'second_options' => array('label' => 'form.new_password_confirmation'),
             'invalid_message' => 'fos_user.password.mismatch',

Form/Type/ProfileFormType.php

@@ -57,6 +57,9 @@ public function buildForm(FormBuilderInterface $builder, array $options)
                 new NotBlank(),
                 new UserPassword($constraintsOptions),
             ),
+            'attr' => array(
+                'autocomplete' => 'current-password',
+            ),
         ));
     }
 

Form/Type/RegistrationFormType.php

@@ -43,7 +43,12 @@ public function buildForm(FormBuilderInterface $builder, array $options)
             ->add('username', null, array('label' => 'form.username', 'translation_domain' => 'FOSUserBundle'))
             ->add('plainPassword', RepeatedType::class, array(
                 'type' => PasswordType::class,
-                'options' => array('translation_domain' => 'FOSUserBundle'),
+                'options' => array(
+                    'translation_domain' => 'FOSUserBundle',
+                    'attr' => array(
+                        'autocomplete' => 'new-password',
+                    ),
+                ),
                 'first_options' => array('label' => 'form.password'),
                 'second_options' => array('label' => 'form.password_confirmation'),
                 'invalid_message' => 'fos_user.password.mismatch',

Form/Type/ResettingFormType.php

@@ -39,7 +39,12 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder->add('plainPassword', RepeatedType::class, array(
             'type' => PasswordType::class,
-            'options' => array('translation_domain' => 'FOSUserBundle'),
+            'options' => array(
+                'translation_domain' => 'FOSUserBundle',
+                'attr' => array(
+                    'autocomplete' => 'new-password',
+                ),
+            ),
             'first_options' => array('label' => 'form.new_password'),
             'second_options' => array('label' => 'form.new_password_confirmation'),
             'invalid_message' => 'fos_user.password.mismatch',

Resources/views/Security/login_content.html.twig

@@ -10,10 +10,10 @@
     {% endif %}
 
     <label for="username">{{ 'security.login.username'|trans }}</label>
-    <input type="text" id="username" name="_username" value="{{ last_username }}" required="required" />
+    <input type="text" id="username" name="_username" value="{{ last_username }}" required="required" autocomplete="username" />
 
     <label for="password">{{ 'security.login.password'|trans }}</label>
-    <input type="password" id="password" name="_password" required="required" />
+    <input type="password" id="password" name="_password" required="required" autocomplete="current-password" />
 
     <input type="checkbox" id="remember_me" name="_remember_me" value="on" />
     <label for="remember_me">{{ 'security.login.remember_me'|trans }}</label>

composer.json

@@ -50,6 +50,11 @@
             "/Tests/"
         ]
     },
+    "autoload-dev": {
+        "psr-4": {
+            "FOS\\UserBundle\\Tests\\": "/Tests/"
+        }
+    },
     "extra": {
         "branch-alias": {
             "dev-master": "2.1.x-dev"