improve WasmConfig initialization for performance and memory ef…#147
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors WasmConfig initialization to simplify configuration and tune Wasmtime engine defaults toward faster execution/instantiation and lower allocator footprint.
Changes:
- Removed the custom
WasmConfigBuilderpath and consolidated configuration intoWasmConfig::default(). - Updated Wasmtime engine defaults (Cranelift opt level, backtrace settings,
memory_init_cow). - Adjusted pooling allocator “warm slot” behavior (reduced from 10 to 1).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+240
to
244
| // Debug build: keep full, symbolized guest backtraces. We are optimizing | ||
| // execution CPU, not trap-path cost, and this is the standalone debug | ||
| // runner — detailed backtraces are the whole point. | ||
| inner.wasm_backtrace(true); | ||
| inner.wasm_backtrace_details(WasmBacktraceDetails::Enable); |
Comment on lines
+277
to
+279
| // No concurrency: at most one instance is ever live, so don't keep extra | ||
| // slots warm (was 10, tuned for a multi-tenant server). | ||
| pooling_allocation_config.max_unused_warm_slots(1); |
qrdl
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ficiency