Skip to content

fix(pdf): preserve logical text in reverse field blocks - #132

Open
GOODBOY008 wants to merge 1 commit into
mainfrom
codex/fix-pr126-reverse-block-pdf
Open

GOODBOY008 wants to merge 1 commit into
mainfrom
codex/fix-pr126-reverse-block-pdf

Conversation

@GOODBOY008

Copy link
Copy Markdown
Owner

A reverse text field (^FPR) combined with ^FB renders correctly but exposes reversed text to PDF search and copy: REVERSE becomes ESREVER. Preserve logical field text separately from visual glyph placement and emit one ActualText span for the entire reverse block, including words split across visual lines.

Add native-PDF regressions for single-line blocks, a wrapped word and a wrapped multiword phrase. This addresses the review finding deferred from #126.

Validation on latest main (dca7488):

  • 350 Rust tests passed, including all 171 raster goldens, diff-report regeneration, and CLI/HTTP vector-output checks.
  • 16 Python tests, 12 PDF structural/search goldens and 49 fixed visual snapshots passed. All six search-probe scene PNGs are byte-identical to the pre-fix output.
  • The complete 175-page corpus passed all strict functional gates in PDFium and Poppler at 1x/3x.
  • cargo fmt --all -- --check and cargo clippy --locked --all-features -- -D warnings passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T04:15:12.145666Z 4792d5e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant