Regen Testing and Calculate Vehicle Speed Off eRPM#504
Open
kzwicker wants to merge 18 commits into
Open
Conversation
dchansen06
added
Enhancement
dchansen06
added
1 URGENT
dchansen06
reviewed
Jun 3, 2026
Contributor
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Lgtm, but lets test on car before merging
Contributor
|
Note that the pr description is changed. |
dchansen06
force-pushed
the
eRPM-to-speed
branch
2 times, most recently
from
089bde1 to
f1b213a
Compare
dchansen06
changed the title
dchansen06
changed the title
dchansen06
force-pushed
the
eRPM-to-speed
branch
2 times, most recently
from
bf6100a to
a69f56f
Compare
Co-authored-by: Thomas Xu <thomasxu070224@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECU Calculate Vehicle Speed
Problem and Scope
At the moment, we don't do that. Now, we will do that.
Description
Pulls eRPM data from the DTI inverter and calculates speed from there. Also uses the "is still" data to determine if the car is moving.
Also, fixes inverter disabling logic by using the correct offsets.
Gotchas and Limitations
The "is still" limit on the DTI inverter may be too sensitive, so the car might register as moving when it isn't
Testing
Testing Details
Requires independent testing
Larger Impact
Allows regen to have a minimum speed threshold
Additional Context and Ticket
Critical to regen