Fix nav bar visibility when searching in add members view#1499
Fix nav bar visibility when searching in add members view#1499martinmitrevski wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: π Files selected for processing (1)
π WalkthroughWalkthroughIn ChangesMemberAddView Search Input Replacement
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~3 minutes Suggested reviewers
Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
βοΈ Tip: You can configure your own custom pre-merge checks in the settings. β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SDK Size
|
StreamChatSwiftUI XCSize
|
| .modifier(factory.styles.makeSearchableModifier( | ||
| options: SearchableModifierOptions(searchText: $viewModel.searchText) | ||
| )) |
There was a problem hiding this comment.
I would prefer we keep the search modifier, we just need to improve it. This change is kinda of a breaking change in terms of behaviour. It seems to me that the ideal fix is to modify the DefaultSearchModifier with this:
.searchable(
text: $searchText,
placement: .navigationBarDrawer(displayMode: .automatic),
prompt: Text(prompt)
)
.searchPresentationToolbarBehavior(.avoidHidingContent)This is only supported on iOS 17.1, but we can change the current version to 17.1 instead of 17.0, then it falls back to a manual implementation (What this PR is doing)
π Issue Links
Resolves https://linear.app/stream/issue/IOS-1750/swiftui-cant-add-members-with-search.
π― Goal
Describe why we are making this change.
π Summary
Provide bullet points with the most important changes in the codebase.
π Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
π¨ Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
π§ͺ Manual Testing Notes
Explain how this change can be tested manually, if applicable.
βοΈ Contributor Checklist
docs-contentrepoSummary by CodeRabbit