Skip to content

[DEVT-2958] feat: resolve codefresh external secrets#220

Merged
vigneshrajsb merged 1 commit into
mainfrom
vb/codefresh-external-secret-resolution
Jun 26, 2026
Merged

[DEVT-2958] feat: resolve codefresh external secrets#220
vigneshrajsb merged 1 commit into
mainfrom
vb/codefresh-external-secret-resolution

Conversation

@vigneshrajsb

@vigneshrajsb vigneshrajsb commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Resolves external secret refs in Codefresh deploy and destroy environment variables before invoking Codefresh.
  • Reuses the existing external-secret processor and waits for synced Kubernetes secrets before passing values to Codefresh.
  • Shell-quotes Codefresh variable values so resolved secrets with apostrophes or shell-like content do not break command execution.
  • Redacts secret-backed Codefresh variables from Lifecycle command logging and shell failure messages.
  • Cleans up temporary Codefresh external-secret resources after destroy resolution so teardown does not leave regenerated secret resources behind.
  • Adds coverage for deploy, destroy, nested object env values, no-secret behavior, missing provider config, missing synced secret keys, shell quoting, destroy cleanup, and destroy cleanup when Codefresh fails.

Validation

  • corepack pnpm test -- src/server/lib/tests/cli.test.ts src/server/lib/tests/codefreshExternalSecrets.test.ts
  • corepack pnpm exec eslint src/server/lib/cli.ts src/server/lib/shell.ts src/server/lib/codefreshExternalSecrets.ts src/server/lib/tests/cli.test.ts src/server/lib/tests/codefreshExternalSecrets.test.ts
  • corepack pnpm exec tsc --project tsconfig.server.json --noEmit --pretty false
  • corepack pnpm run lint
  • corepack pnpm test -- --testPathIgnorePatterns=.claude/worktrees

Notes

  • Raw secret values are not included in this PR description or tests.
  • Full pnpm test without ignoring local .claude/worktrees is noisy in this workspace because Jest discovers duplicate checked-out worktrees; rerunning with that local directory ignored passed.
  • pnpm run ts-check was attempted and is blocked by existing repo-wide type issues unrelated to this patch; the server typecheck listed above passes.

@vigneshrajsb vigneshrajsb force-pushed the vb/codefresh-external-secret-resolution branch from 56b0ee3 to ee6941a Compare June 26, 2026 19:33
@vigneshrajsb vigneshrajsb force-pushed the vb/codefresh-external-secret-resolution branch from ee6941a to 82b7e07 Compare June 26, 2026 19:36
@vigneshrajsb vigneshrajsb marked this pull request as ready for review June 26, 2026 23:13
@vigneshrajsb vigneshrajsb requested a review from a team as a code owner June 26, 2026 23:13
@vigneshrajsb vigneshrajsb merged commit c733cd4 into main Jun 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant