Skip to content

Migrate partially resource_compute_instance.go.tmpl to use direct HTTP rather than a client library#17536

Draft
nsamartsev wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-instance-alias-ip-refactor
Draft

Migrate partially resource_compute_instance.go.tmpl to use direct HTTP rather than a client library#17536
nsamartsev wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-instance-alias-ip-refactor

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrate partially `resource_compute_instance.go.tmpl` to use direct HTTP rather than a client library

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 825dab2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 76 insertions(+), 37 deletions(-)
google-beta provider View Diff 2 files changed, 76 insertions(+), 37 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1446 1351 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 825dab2!

@nsamartsev nsamartsev force-pushed the resource-compute-instance-alias-ip-refactor branch from 825dab2 to d058a74 Compare May 14, 2026 20:18
@nsamartsev nsamartsev force-pushed the resource-compute-instance-alias-ip-refactor branch from d058a74 to 93439f2 Compare May 14, 2026 20:25
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d058a74:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 411 insertions(+), 262 deletions(-)
google-beta provider View Diff 2 files changed, 442 insertions(+), 276 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • compute

Please fix the compilation errors to complete your PR.

View the build log

@nsamartsev VCR tests complete for d058a74!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 93439f2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 409 insertions(+), 268 deletions(-)
google-beta provider View Diff 2 files changed, 440 insertions(+), 282 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1447 1267 93 87
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 87 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeAutoscaler_multicondition
  • TestAccComputeAutoscaler_scaleDownControl
  • TestAccComputeAutoscaler_scaleInControl
  • TestAccComputeAutoscaler_scaleInControlFixed
  • TestAccComputeAutoscaler_scalingSchedule
  • TestAccComputeAutoscaler_update
  • TestAccComputeForwardingRule_forwardingRuleBasicExample
  • TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
  • TestAccComputeForwardingRule_ip
  • TestAccComputeForwardingRule_networkTier
  • TestAccComputeForwardingRule_serviceDirectoryRegistrations
  • TestAccComputeForwardingRule_update
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeInstance_GracefulShutdownWithResetUpdate
  • TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
  • TestAccComputeInstance_NicStackTypeUpdate
  • TestAccComputeInstance_PTRRecord
  • TestAccComputeInstance_advancedMachineFeatures
  • TestAccComputeInstance_aliasIpRangeCommonAddresses
  • TestAccComputeInstance_attachedDiskUpdate
  • TestAccComputeInstance_autoDeleteUpdate
  • TestAccComputeInstance_bootDiskUpdate
  • TestAccComputeInstance_creationOnlyAttributionLabel
  • TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse
  • TestAccComputeInstance_descriptionUpdate
  • TestAccComputeInstance_desiredStatusSuspendedOnCreation
  • TestAccComputeInstance_desiredStatusTerminatedOnCreation
  • TestAccComputeInstance_desiredStatusTerminatedUpdateFields
  • TestAccComputeInstance_desiredStatusUpdateBasic
  • TestAccComputeInstance_desiredStatus_suspended
  • TestAccComputeInstance_diskEncryptionRestart
  • TestAccComputeInstance_enableDisplay
  • TestAccComputeInstance_hostErrorTimeoutSecconds
  • TestAccComputeInstance_instanceEncryption
  • TestAccComputeInstance_metadataStartupScript_gracefulSwitch
  • TestAccComputeInstance_metadataStartupScript_update
  • TestAccComputeInstance_minCpuPlatform
  • TestAccComputeInstance_partnerMetadata_deletePartnerMetadata
  • TestAccComputeInstance_partnerMetadata_update
  • TestAccComputeInstance_performanceMonitoringUnit
  • TestAccComputeInstance_resourceManagerTags
  • TestAccComputeInstance_resourcePolicyUpdate
  • TestAccComputeInstance_schedulingSkipGuestOSShutdown
  • TestAccComputeInstance_secondaryAliasIpRange
  • TestAccComputeInstance_serviceAccount_updated
  • TestAccComputeInstance_serviceAccount_updated0to1to0scopes
  • TestAccComputeInstance_shieldedVmConfig
  • TestAccComputeInstance_soleTenantNodeAffinities
  • TestAccComputeInstance_stopInstanceToUpdate
  • TestAccComputeInstance_subnetworkUpdate
  • TestAccComputeInstance_update
  • TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate
  • TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate
  • TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate
  • TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate
  • TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate
  • TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate
  • TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate
  • TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate
  • TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate
  • TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate
  • TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeRegionAutoscaler_scaleDownControl
  • TestAccComputeRegionAutoscaler_scaleInControl
  • TestAccComputeRegionAutoscaler_scalingSchedule
  • TestAccComputeRegionAutoscaler_update
  • TestAccComputeRegionDisk_deleteDetach
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
  • TestAccComputeTargetPool_update
  • TestAccComputeTargetPool_withSecurityPolicy
  • TestAccDataSourceGoogleComputeInstanceGroupManager
  • TestAccDataSourceGoogleComputeRegionInstanceGroupManager
  • TestAccDataSourceGoogleForwardingRule
  • TestAccDataSourceGoogleForwardingRules
  • TestAccInstanceGroupManager_autoHealingPolicies
  • TestAccInstanceGroupManager_basic
  • TestAccInstanceGroupManager_self_link_unique
  • TestAccInstanceGroupManager_stateful
  • TestAccInstanceGroupManager_update
  • TestAccInstanceGroupManager_waitForStatus
  • TestAccRegionInstanceGroupManager_autoHealingPolicies
  • TestAccRegionInstanceGroupManager_basic
  • TestAccRegionInstanceGroupManager_update

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeAutoscaler_multicondition
✅ Log TestAccComputeAutoscaler_scaleDownControl
✅ Log TestAccComputeAutoscaler_scaleInControl
✅ Log TestAccComputeAutoscaler_scaleInControlFixed
✅ Log TestAccComputeAutoscaler_scalingSchedule
✅ Log TestAccComputeAutoscaler_update
✅ Log TestAccComputeForwardingRule_forwardingRuleBasicExample
✅ Log TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
✅ Log TestAccComputeForwardingRule_networkTier
✅ Log TestAccComputeForwardingRule_serviceDirectoryRegistrations
✅ Log TestAccComputeForwardingRule_update
✅ Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/two_nics_access_config_with_empty_nil_security_policy
✅ Log TestAccComputeInstance_GracefulShutdownWithResetUpdate
✅ Log TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
✅ Log TestAccComputeInstance_NicStackTypeUpdate
✅ Log TestAccComputeInstance_advancedMachineFeatures
✅ Log TestAccComputeInstance_aliasIpRangeCommonAddresses
✅ Log TestAccComputeInstance_attachedDiskUpdate
✅ Log TestAccComputeInstance_autoDeleteUpdate
✅ Log TestAccComputeInstance_bootDiskUpdate
✅ Log TestAccComputeInstance_creationOnlyAttributionLabel
✅ Log TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse
✅ Log TestAccComputeInstance_descriptionUpdate
✅ Log TestAccComputeInstance_desiredStatusSuspendedOnCreation
✅ Log TestAccComputeInstance_desiredStatusTerminatedOnCreation
✅ Log TestAccComputeInstance_desiredStatusTerminatedUpdateFields
✅ Log TestAccComputeInstance_desiredStatusUpdateBasic
✅ Log TestAccComputeInstance_desiredStatus_suspended
✅ Log TestAccComputeInstance_enableDisplay
✅ Log TestAccComputeInstance_hostErrorTimeoutSecconds
✅ Log TestAccComputeInstance_instanceEncryption
✅ Log TestAccComputeInstance_metadataStartupScript_gracefulSwitch
✅ Log TestAccComputeInstance_metadataStartupScript_update
✅ Log TestAccComputeInstance_minCpuPlatform
✅ Log TestAccComputeInstance_partnerMetadata_deletePartnerMetadata
✅ Log TestAccComputeInstance_partnerMetadata_update
✅ Log TestAccComputeInstance_performanceMonitoringUnit
✅ Log TestAccComputeInstance_resourceManagerTags
✅ Log TestAccComputeInstance_resourcePolicyUpdate
✅ Log TestAccComputeInstance_schedulingSkipGuestOSShutdown
✅ Log TestAccComputeInstance_serviceAccount_updated
✅ Log TestAccComputeInstance_serviceAccount_updated0to1to0scopes
✅ Log TestAccComputeInstance_shieldedVmConfig
✅ Log TestAccComputeInstance_soleTenantNodeAffinities
✅ Log TestAccComputeInstance_stopInstanceToUpdate
✅ Log TestAccComputeInstance_subnetworkUpdate
✅ Log TestAccComputeInstance_update
✅ Log TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate
✅ Log TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate
✅ Log TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate
✅ Log TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate
✅ Log TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate
✅ Log TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate
✅ Log TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate
✅ Log TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate
✅ Log TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate
✅ Log TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate
✅ Log TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log TestAccComputeRegionAutoscaler_scaleDownControl
✅ Log TestAccComputeRegionAutoscaler_scaleInControl
✅ Log TestAccComputeRegionAutoscaler_scalingSchedule
✅ Log TestAccComputeRegionAutoscaler_update
✅ Log TestAccComputeRegionDisk_deleteDetach
✅ Log TestAccComputeTargetPool_update
✅ Log TestAccComputeTargetPool_withSecurityPolicy
✅ Log TestAccDataSourceGoogleComputeInstanceGroupManager
✅ Log TestAccDataSourceGoogleComputeRegionInstanceGroupManager
✅ Log TestAccDataSourceGoogleForwardingRule
✅ Log TestAccDataSourceGoogleForwardingRules
✅ Log TestAccInstanceGroupManager_autoHealingPolicies
✅ Log TestAccInstanceGroupManager_basic
✅ Log TestAccInstanceGroupManager_self_link_unique
✅ Log TestAccInstanceGroupManager_stateful
✅ Log TestAccInstanceGroupManager_update
✅ Log TestAccInstanceGroupManager_waitForStatus
✅ Log TestAccRegionInstanceGroupManager_autoHealingPolicies
✅ Log TestAccRegionInstanceGroupManager_basic
✅ Log TestAccRegionInstanceGroupManager_update
❌ Error · Log - TestAccComputeForwardingRule_ip
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/access_config_update_access_config
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/two_access_config
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/two_access_config_update_policy_with_stopped_machine
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/two_nics_two_access_configs_update_one_policy
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/two_nics_two_access_configs_update_remove_access_config
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/two_nics_two_access_configs_update_two_policies
❌ Error · Log - TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy/wit_no_access_config
❌ Error · Log - TestAccComputeInstance_PTRRecord
❌ Error · Log - TestAccComputeInstance_diskEncryptionRestart
❌ Error · Log - TestAccComputeInstance_secondaryAliasIpRange
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 93439f2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants