Skip to content

⚡ [performance improvement] Optimize Firestore snapshot data extraction #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-ostapenko wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −21
Open

⚡ [performance improvement] Optimize Firestore snapshot data extraction #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7241a05
perf: optimize Firestore snapshot data extraction using docs.map
max-ostapenko Mar 26, 2026
b13b3a5
Delete src/benchmarks/queryCopy.benchmark.js
max-ostapenko Apr 15, 2026
fe7d9d7
Delete src/tests/optimization.test.js
max-ostapenko Apr 15, 2026
a9f0897
merge: resolve conflicts with origin/main and extend docs.map optimiz…
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/utils/controllerHelpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,7 @@ const executeQuery = async (req, res, collection, queryBuilder, dataProcessor =
const query = await queryBuilder(params);
const snapshot = await query.get();

let data = [];
snapshot.forEach(doc => {
data.push(doc.data());
});
let data = snapshot.docs.map(doc => doc.data());

// Process data if processor provided
if (dataProcessor) {
Expand Down
23 changes: 6 additions & 17 deletions src/utils/reportService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ export const queryTechnologies = async (params = {}) => {
}

const snapshot = await query.get();
const data = [];
snapshot.forEach(doc => data.push(doc.data()));
const data = snapshot.docs.map(doc => doc.data());

if (isOnlyNames) {
return data.map(item => item.technology);
Expand Down Expand Up @@ -102,8 +101,7 @@ export const queryCategories = async (params = {}) => {
}

const snapshot = await query.get();
const data = [];
snapshot.forEach(doc => data.push(doc.data()));
const data = snapshot.docs.map(doc => doc.data());

if (isOnlyNames) {
return data.map(item => item.category);
Expand Down Expand Up @@ -149,10 +147,7 @@ export const queryReport = async (reportType, params = {}) => {
}

const snapshot = await query.get();
const data = [];
snapshot.forEach(doc => data.push(doc.data()));

return data;
return snapshot.docs.map(doc => doc.data());
};

export const queryCWVDistribution = async ({ technology, date, geo = 'ALL', rank = null }) => {
Expand Down Expand Up @@ -275,9 +270,7 @@ export const queryRanks = async () => {
.orderBy('mobile_origins', 'desc')
.select('rank')
.get();
const data = [];
snapshot.forEach(doc => data.push(doc.data()));
return data;
return snapshot.docs.map(doc => doc.data());
};

export const queryGeos = async () => {
Expand All @@ -286,9 +279,7 @@ export const queryGeos = async () => {
.orderBy('mobile_origins', 'desc')
.select('geo')
.get();
const data = [];
snapshot.forEach(doc => data.push(doc.data()));
return data;
return snapshot.docs.map(doc => doc.data());
};

export const queryVersions = async (params = {}) => {
Expand Down Expand Up @@ -317,7 +308,5 @@ export const queryVersions = async (params = {}) => {
}

const snapshot = await query.get();
const data = [];
snapshot.forEach(doc => data.push(doc.data()));
return data;
return snapshot.docs.map(doc => doc.data());
};