Skip to content

fix(web): pass login state to useUnreadCount in Header #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haseeb-MernStack merged 1 commit into from
Oct 27, 2026
Merged

fix(web): pass login state to useUnreadCount in Header #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions apps/web/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,16 @@ export const AUTH_PATHS = ["/login", "/register", "/forgot-password", "/reset-pa

function MenuIcon({ open }: { open: boolean }) {
return (
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" aria-hidden>
<svg
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
strokeWidth="2"
strokeLinecap="round"
aria-hidden
>
{open ? <path d="M6 6l12 12M18 6L6 18" /> : <path d="M4 7h16M4 12h16M4 17h16" />}
</svg>
);
Expand All @@ -20,7 +29,7 @@ function MenuIcon({ open }: { open: boolean }) {
export default function Header() {
const { user, logout } = useAuth();
const { pathname } = useLocation();
const unread = useUnreadCount();
const unread = useUnreadCount(Boolean(user));
const [open, setOpen] = useState(false);
const count = unread.data?.count ?? 0;
const countLabel = count > 99 ? "99+" : String(count);
Expand Down Expand Up @@ -91,10 +100,17 @@ export default function Header() {
<NavLink to="/communities" className={navClass}>
Communities
</NavLink>
<NavLink to={user.plus ? "/insights" : "/plus"} className={({ isActive }) => `${navClass({ isActive })} plus-link`}>
<NavLink
to={user.plus ? "/insights" : "/plus"}
className={({ isActive }) => `${navClass({ isActive })} plus-link`}
>
{user.plus ? "Insights" : "✦ Plus"}
</NavLink>
<NavLink to="/notifications" className={navClass} aria-label={`Notifications, ${count} unread`}>
<NavLink
to="/notifications"
className={navClass}
aria-label={`Notifications, ${count} unread`}
>
🔔
{count > 0 && <span className="badge">{countLabel}</span>}
</NavLink>
Expand All @@ -112,7 +128,11 @@ export default function Header() {
{/* Mobile / tablet controls */}
<div className="nav-mobile">
{user && (
<Link to="/notifications" className="icon-btn" aria-label={`Notifications, ${count} unread`}>
<Link
to="/notifications"
className="icon-btn"
aria-label={`Notifications, ${count} unread`}
>
🔔
{count > 0 && <span className="badge">{countLabel}</span>}
</Link>
Expand All @@ -131,8 +151,19 @@ export default function Header() {

{/* Slide-in menu (right side) */}
<div className={`drawer-root${open ? " open" : ""}`} aria-hidden={!open}>
<button className="drawer-overlay" tabIndex={-1} aria-label="Close menu" onClick={() => setOpen(false)} />
<aside id="mobile-menu" className="drawer" role="dialog" aria-modal="true" aria-label="Menu">
<button
className="drawer-overlay"
tabIndex={-1}
aria-label="Close menu"
onClick={() => setOpen(false)}
/>
<aside
id="mobile-menu"
className="drawer"
role="dialog"
aria-modal="true"
aria-label="Menu"
>
{user ? (
<>
<Link to={`/u/${user.username}`} className="drawer-profile">
Expand Down
Loading