Sunm 36153 - update delayed_gem with Rails 6.1 compatible changes#6
Open
swatikri-ht wants to merge 37 commits into
Open
Sunm 36153 - update delayed_gem with Rails 6.1 compatible changes#6swatikri-ht wants to merge 37 commits into
swatikri-ht wants to merge 37 commits into
Conversation
Also bump the Ruby versions tested against.
Allow Rails 5.2 to be used
While I believe 6 is the next planned release, plans can change.
Limit the rails 5.0 build matrix as 5.0 is no longer supported by the rails community. As with the other versions we don't have a good reason to break support but we don't need to tax travis building every combination.
This is a service we no longer use.
The term REMOVED was misleading when destroy_failed_jobs = false. The term FAILED is not misleading, and is also used elsewhere in similar contexts, so is more conventional.
It seems to be a preferred by the Rails team.
fix broken link
These are soon to be deprecated and render very poorly on most high density displays. Here's a visual diff from a 2015 Retina MacBook Pro: http://link.olivierlacan.com/e15d4429a85f
However, the relaxed activerecord requirement is not yet in released versions of the gems
The divided load was triggering errors when encountering an unexpected load order. This allows the dependencies to properly load in any configuration.
It is very rare to hit this, but Rails uses it to handle class renames so data can deserialize after upgrading rails. rails/rails@c3675f5#diff-0543aa8566327ece879b8ce6f394d391R185 This update allows us to handle either version of the load_tags data.
With the update to better handle disabling ActionMailer there is an edge case where Delayed::PerformableMailer isn't always loaded when it is needed.
New rails versions are cut and rails 6 actually requires it
We can remove the rails 6.1 part when 61.0 is released
swatikri-ht
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.