Cleanup feature flags#3002
Open
StylianosGakis wants to merge 7 commits into
Open
Conversation
# Conflicts: # app/feature/feature-help-center/src/commonMain/kotlin/com/hedvig/android/feature/help/center/di/HelpCenterModule.kt # app/featureflags/feature-flags/src/androidMain/kotlin/com/hedvig/android/featureflags/flags/UnleashFeatureFlagProvider.kt # app/featureflags/feature-flags/src/commonMain/kotlin/com/hedvig/android/featureflags/flags/Feature.kt
Remove MOVING_FLOW, PAYMENT_SCREEN, EDIT_COINSURED and HELP_CENTER (all at 100% rollout) along with the dead DISABLE_REDEEM_CAMPAIGN, collapsing each flag check to its enabled behavior. Also wire ALWAYS_AVAILABLE_INBOX_AND_NEW_CHAT to its Unleash key.
Delete ENABLE_CLAIM_HISTORY, ENABLE_VIDEO_PLAYER_IN_CHAT_MESSAGES, TRAVEL_ADDON, and TERMINATION_FLOW as we never turn those off Rework the remaining flags so each Feature enum name mirrors its Unleash key polarity (DISABLE_PUPPY_GUIDE, ENABLE_NEW_CONVERSATION_FROM_INBOX). UnleashFeatureFlagProvider now returns the raw isEnabled(key) for every flag, and kill-switch consumers invert at the read site. Due to the "default value" unleash problem, this means that each feature flag makes a more concious decision of what its "default" behavior is when we have failed to fetch it, depending on if it's a kill-switch style flag or a turn-on style flag. The `bootstrap` parameter in the `UnleashClient.start` function allows us to control that default ourselves instead before we ever get a proper first response from the backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More discussion here: https://hedviginsurance.slack.com/archives/C03U9C6Q7TP/p1782137564494479
Delete ENABLE_CLAIM_HISTORY, ENABLE_VIDEO_PLAYER_IN_CHAT_MESSAGES,
TRAVEL_ADDON, and TERMINATION_FLOW as we never turn those off
Rework the remaining flags so each Feature enum name mirrors its Unleash
key polarity (DISABLE_PUPPY_GUIDE, ENABLE_NEW_CONVERSATION_FROM_INBOX).
UnleashFeatureFlagProvider now returns the raw isEnabled(key) for every
flag, and kill-switch consumers invert at the read site.
Due to the "default value" unleash problem, this means that each
feature flag makes a more concious decision of what its "default"
behavior is when we have failed to fetch it, depending on if it's a
kill-switch style flag or a turn-on style flag.
The
bootstrapparameter in theUnleashClient.startfunction allowsus to control that default ourselves instead before we ever get a
proper first response from the backend