You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we have node_table_get_row in #132, it would make sense to implement *_table_get_row method for all tables. Seems very doable. It would also enable us testing of the *_table_add_row methods - do we get back what we have put in the tables.
Edit: Note that we don't, yet, at the time of writing have add_row methods for all the tables - see #137
At the moment, the node_table_get_row works on TableCollection only, but in Python we can get a row of tables stored both in TableCollection and in TreeSequence and C method is for the node table (https://tskit.dev/tskit/docs/stable/c-api.html#c.tsk_node_table_get_row) not for TableCollection or TreeSequence. So, how should we address this in RcppTskit?
Activity
gregorgorjanc commentedon Apr 13, 2026
At the moment, the
node_table_get_rowworks onTableCollectiononly, but in Python we can get a row of tables stored both inTableCollectionand inTreeSequenceand C method is for the node table (https://tskit.dev/tskit/docs/stable/c-api.html#c.tsk_node_table_get_row) not forTableCollectionorTreeSequence. So, how should we address this inRcppTskit?Any suggestions?
gregorgorjanc commentedon Aug 19, 2026
Will close this as we now have this in #132 and we can discuss
TreeSequencemethods as part of #138 or similar issue as the need arises.