Skip to content

Fix CSP spec, add shared component stories, add API versioning policy - #1961

Merged
Gbangbolaoluwagbemiga merged 1 commit into
HyperSafeD:mainfrom
devjayy43:fix/csp-stories-api-versioning-1874-1875-1881
Oct 22, 2026
Merged

Gbangbolaoluwagbemiga merged 1 commit into
HyperSafeD:mainfrom
devjayy43:fix/csp-stories-api-versioning-1874-1875-1881

Conversation

@devjayy43

Copy link
Copy Markdown
Contributor

Summary

Minimal fixes for three of the four issues from the frontend/docs audit.

Not included: #1882 (providers). The providers have no async initialization that fails silently. There is no auth provider, and DashboardProvider has no promise chain. The only unguarded storage access is synchronous localStorage reads in ThemeProvider and WorkspaceProvider, which throw rather than fail silently. No change made, so this PR does not close #1882.

Remaining gaps

  • Storybook stories still missing for shared components: Breadcrumbs (depends on next/navigation), DashboardHeader, KeyboardShortcuts, ComparisonView, TrendPanel, and Dashboard.
  • csp-security.spec.ts still has a pre-existing @ts-ignore and an unused @ts-expect-error, both in the first test. Not touched here.

Verification

  • npx playwright test tests/e2e/csp-security.spec.ts: 2 passed (dev server, Chromium).
  • npx storybook build: succeeds with the new stories.
  • npx tsc --noEmit: 13 errors, all pre-existing; none in the changed files.
  • npx eslint on the changed files: only the pre-existing @ts-ignore finding.

Closes #1874
Closes #1875
Closes #1881
Closes #1882

- csp-security.spec: assert the CSP script-src served for /playground
  (no route interception), and fix the duplicated `logs` declaration
  that stopped the spec from loading.
- Add Storybook stories for shared components: Skeleton, RiskBadge,
  CallGraphSkeleton, AnalysisTerminal, TrendChart.
- Add docs/api-versioning.md describing the v1 deprecation policy.
@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

@devjayy43 is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@devjayy43 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Gbangbolaoluwagbemiga
Gbangbolaoluwagbemiga merged commit d20a4a9 into HyperSafeD:main Oct 22, 2026
19 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment