Repository navigation
Fix CSP spec, add shared component stories, add API versioning policy - #1961
Merged
Gbangbolaoluwagbemiga merged 1 commit intoOct 22, 2026
Conversation
- csp-security.spec: assert the CSP script-src served for /playground (no route interception), and fix the duplicated `logs` declaration that stopped the spec from loading. - Add Storybook stories for shared components: Skeleton, RiskBadge, CallGraphSkeleton, AnalysisTerminal, TrendChart. - Add docs/api-versioning.md describing the v1 deprecation policy.
|
@devjayy43 is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devjayy43 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Gbangbolaoluwagbemiga
merged commit Oct 22, 2026
d20a4a9
into
HyperSafeD:main
19 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal fixes for three of the four issues from the frontend/docs audit.
csp-security.spec.tsonly asserted a CSP it injected throughpage.route, so it never checked the header Next.js serves. Added a test that loads/playgroundwithout interception and asserts the servedscript-srcis exactly'self'. The playground does not use WASM or eval, so no per-route override is needed. Also fixed a duplicatedconst logsdeclaration in the same spec, which stopped the file from loading, and moved the console listener before navigation so load-time violations are captured.Skeleton,RiskBadge,CallGraphSkeleton,AnalysisTerminal,TrendChart. Not every shared component is covered yet (see below).docs/api-versioning.mdwith a v1 deprecation policy (Deprecation/Sunset headers, migration doc, notice period). The 6-month notice period and header requirements are a proposed policy for maintainers to confirm.Not included: #1882 (providers). The providers have no async initialization that fails silently. There is no auth provider, and
DashboardProviderhas no promise chain. The only unguarded storage access is synchronouslocalStoragereads inThemeProviderandWorkspaceProvider, which throw rather than fail silently. No change made, so this PR does not close #1882.Remaining gaps
Breadcrumbs(depends onnext/navigation),DashboardHeader,KeyboardShortcuts,ComparisonView,TrendPanel, andDashboard.csp-security.spec.tsstill has a pre-existing@ts-ignoreand an unused@ts-expect-error, both in the first test. Not touched here.Verification
npx playwright test tests/e2e/csp-security.spec.ts: 2 passed (dev server, Chromium).npx storybook build: succeeds with the new stories.npx tsc --noEmit: 13 errors, all pre-existing; none in the changed files.npx eslinton the changed files: only the pre-existing@ts-ignorefinding.Closes #1874
Closes #1875
Closes #1881
Closes #1882