Repository navigation
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Kwon Yeseol <172019512+yeseorizi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing one-way Gazebo → ROS
/clockbridge to the standalone REXROV and Slocum glider robot configurations.On
main(0d19c3f), Gazebo can be running while a ROS node withuse_sim_time=trueremains at time zero for these examples. Both configurations omit the clock mapping./clock@rosgraph_msgs/msg/Clock[gz.msgs.Clockto each configuration.Reproduction and validation
ros_gz_bridgeshutdown overlay, which is not part of this PR.pre-commitchecks passed.colcon build --packages-select posim_robot_models --cmake-args -DBUILD_TESTING=ON ctest --test-dir build/posim_robot_models --output-on-failure \ -R '^test_' --repeat until-fail:10Scope / limitations
Tested in Ubuntu 26.04 ARM64 Docker on an Apple Silicon Mac, ROS 2 Lyrical / Gazebo Jetty 10.5.0. This covers the documented standalone launches, not a multi-world/multi-clock configuration or full-release validation.
The existing locally patched
asv_wave_simdependency also remained installed during scene checks. Neither that renderer teardown patch nor the bridge overlay is included in this PR; successful scene cleanup is not attributed to this change alone.Checklist
pre-commit.colcon test/ all platforms validated (outside this scoped fix).Assisted-by: OpenAI Codex (implementation, tests and PR preparation).