fix: strip @infragistics/ scope from imports in generated code-viewer JSON#1082
Merged
ChronosSF merged 1 commit intoJun 17, 2026
Merged
Conversation
ChronosSF
approved these changes
Jun 17, 2026
There was a problem hiding this comment.
Pull request overview
This PR prevents licensed @infragistics/igniteui-* scoped package names (introduced by the CI rewrite step) from leaking into the docs site’s generated code-viewer JSON, so end users see the public igniteui-* package imports instead.
Changes:
- Strip
@infragistics/scope fromigniteui-*imports when copying sample sources into./src/samples. - Strip
@infragistics/scope from the main TSX sample source before writing it into the code-viewer JSON.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChronosSF
deleted the
dtsvetkov/strip-official-package-from-generated-jsons
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI/CD pipeline rewrites all
igniteui-reactandigniteui-dockmanagerimport strings in source .tsx/.ts files to their licensed @infragistics/ scoped equivalents before running the build. Since gulp updateBrowser runs as part of the build, getSamples reads the already rewritten source files and updateCodeViewer embeds them into the generated code-viewer JSON files. As a result, end users in the docs site code viewer would see@infragistics/igniteui-react-*imports packages that require a license and are not publicly available on npm.