Repository navigation
Conversation
|
💬 Discussion in Slack: #pr-review-cli-445-refac-json-to-yaml-remove-the-auto-migration-to-yaml Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
@claude review again and check if the previous comments were fixed. The same behavior that happens on JSON was kept. |
There was a problem hiding this comment.
Code review completed
Nothing new to post: everything this review found is already covered by existing comments on this pull request or didn't merit a separate one.
Still open from earlier reviews (1):
- 🔴
packages/util/config.go:135—Users who add only environment.overrides and keep default-environment silently get the flag default environment (e.g. d…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
[Medium impact] The PR appears safe to merge; no new actionable issues remain.
|
Description 📣
This PR removes the auto migration to yaml. Only new configs will be defined using yaml. The .json continue to work
Type ✨
Tests 🛠️
override) wins