Skip to content

refac(json-to-yaml): remove the auto migration to yaml - #445

Open
adilsitos wants to merge 7 commits into
mainfrom
yaml-environment-overrides
Open

adilsitos wants to merge 7 commits into
mainfrom
yaml-environment-overrides

Conversation

@adilsitos

Copy link
Copy Markdown
Contributor

Description 📣

This PR removes the auto migration to yaml. Only new configs will be defined using yaml. The .json continue to work

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

  • create a new config file using infisical init
  • check the structure that was created.
  • check that the old yaml structure continues to be supported
  • check that if you have the new and the old yaml structure, the new one (override) wins

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-445-refac-json-to-yaml-remove-the-auto-migration-to-yaml

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread packages/util/config.go Outdated
Comment thread packages/util/helper.go Outdated
Comment thread packages/cmd/init.go Outdated
Comment thread packages/models/cli.go Outdated
@adilsitos
adilsitos requested a review from varonix0 October 20, 2026 00:04
@adilsitos

Copy link
Copy Markdown
Contributor Author

@claude review again and check if the previous comments were fixed. The same behavior that happens on JSON was kept.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed

Nothing new to post: everything this review found is already covered by existing comments on this pull request or didn't merit a separate one.

Still open from earlier reviews (1):

  • 🔴 packages/util/config.go:135 — Users who add only environment.overrides and keep default-environment silently get the flag default environment (e.g. d…

If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable issues remain.

Summary

Removes automatic JSON-to-YAML migration while keeping existing JSON configs supported.

  • YAML project files accept the newer environment and branch settings.
  • Reading an old JSON project no longer creates a YAML file.
  • Running init creates YAML and leaves any older JSON file in place.
  • General migration notices are no longer shown by the CLI.

Reviews (2) · Last reviewed commit: "update yaml format" · Reviewed by Greptile

Comment thread packages/util/config.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants