feat: agent vault mcp server by sheensantoscapadngan · Pull Request #8672 · Infisical/infisical

sheensantoscapadngan · 2026-10-15T16:45:17Z

Context

This PR adds support for MCP proxying via Agent Vault

Relevant PR:
Infisical/cli#436

Screenshots

Steps to verify the change

Type

Checklist

Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
Tested locally
Updated docs (if needed)
Updated CLAUDE.md files (if needed)
Read the contributing guide

infisical-review-police · 2026-10-15T16:45:21Z

💬 Discussion in Slack: #pr-review-infisical-8672-feat-mcp-proxy

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

chatgpt-codex-connector · 2026-10-15T16:45:26Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-15T16:45:21.325039Z	`748266a`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-15T16:45:29Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

socket-security · 2026-10-15T16:46:24Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/oauth4webapi@3.8.3 ⏵ 3.8.8

View full report

greptile-apps · 2026-10-15T16:57:49Z

Confidence Score: 5/5

[High impact] The PR appears safe to merge, with two non-blocking improvements to refresh frequency and outage feedback.

Findings

Shared sessions refresh repeatedly ▶
Outages trigger wrong setup ▶

Summary

Adds remote MCP services to Agent Vault, with OAuth setup, token refresh, service templates, and MCP details in session logs.

Admins can add MCP servers to Agent Vault access bundles.
MCP services can use OAuth tokens authorized for their server.
The session proxy forwards MCP requests with their service credentials.
Session logs identify MCP methods and tool names.

_{Reviews (18) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile}

mintlify · 2026-10-15T21:45:03Z

Preview deployment for your docs. Learn more about Mintlify Previews.

Project	Status	Preview	Updated
infisical	🟢 Ready	View Preview	Oct 27, 2026, 4:49 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

- Drop the box, shield icon and badges; one status line, one sentence and one button per state - Before authorizing, show only "Authorize with <host>"; waiting lives in the button with Cancel - Use the shared status labels, a fixed "Authorized on" date, and plain-text scopes that wrap and collapse after 10 - Show a failed refresh as one line with the server's reason on hover, muted under Needs Additional Scopes - Keep the saved scopes visible when a reauthorization fails - "Use your own OAuth app" link on first connect too, with the redirect URI, an instruction and side-by-side client fields - Auth Method as a Select, "Advanced Options" label, and the Sends preview only when a header is customized - Rename "OAuth 2.1" to "OAuth", drop the unused popup-closed tracking, and keep the callback popup open on failure - Update mcp-servers.mdx for the new labels

…feat-agent-vault-mcp-proxy # Conflicts: # backend/package-lock.json # backend/package.json # backend/src/@types/fastify.d.ts # backend/src/ee/routes/v1/agent-vault-routers/agent-vault-access-bundle-router.ts # backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.ts # backend/src/ee/services/agent-vault-proxy/agent-vault-proxy-service.ts # backend/src/server/routes/index.ts # frontend/src/components/agent-vault/ServiceIconStack.tsx # frontend/src/components/agent-vault/service-sheet/ServiceSheet.tsx # frontend/src/components/agent-vault/service-sheet/serviceSchema.ts # frontend/src/components/agent-vault/service-sheet/stepMeta.ts # frontend/src/pages/agent-vault/AgentVaultAccessBundleDetailPage/AgentVaultAccessBundleDetailPage.tsx

linear · 2026-10-26T17:13:29Z

…eensantoscapadngan/feat-agent-vault-mcp-proxy # Conflicts: # backend/e2e-test/routes/v1/agent-vault.spec.ts # backend/src/@types/fastify.d.ts # backend/src/db/sanitized-schema.yaml # backend/src/db/schemas/agent-vault-services.ts # backend/src/ee/routes/v1/agent-vault-routers/agent-vault-access-bundle-router.ts # backend/src/ee/routes/v1/agent-vault-routers/agent-vault-proxy-agent-router.ts # backend/src/ee/routes/v1/agent-vault-routers/agent-vault-schemas.ts # backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.ts # backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-types.ts # backend/src/ee/services/agent-vault-access-bundle/agent-vault-service-dal.ts # backend/src/ee/services/agent-vault-proxy/agent-vault-proxy-service.ts # backend/src/ee/services/agent-vault/AGENTS.md # backend/src/keystore/keystore.ts # backend/src/server/routes/index.ts # docs/documentation/platform/agent-vault/plan-your-setup.mdx # docs/documentation/platform/agent-vault/proxies.mdx # docs/documentation/platform/agent-vault/services.mdx # docs/documentation/platform/agent-vault/session-logs.mdx # frontend/src/components/agent-vault/ServiceTemplateSelect.tsx # frontend/src/components/agent-vault/service-sheet/CredentialFields.tsx # frontend/src/components/agent-vault/service-sheet/ReviewFields.tsx # frontend/src/components/agent-vault/service-sheet/ServiceSheet.tsx # frontend/src/components/agent-vault/service-sheet/serviceSchema.ts # frontend/src/components/agent-vault/service-sheet/stepMeta.ts # frontend/src/hooks/api/agentVault/mutations.tsx # frontend/src/hooks/api/agentVault/queries.tsx # frontend/src/hooks/api/agentVault/types.ts # frontend/src/pages/agent-vault/AgentVaultAccessBundleDetailPage/components/ServicesCard.tsx

gitguardian · 2026-10-26T22:11:26Z

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
38833010	Triggered	Username Password	`7fa9d1e`	backend/src/ee/services/agent-vault-access-bundle/agent-vault-credential-write-fns.test.ts	View secret
38833011	Triggered	Generic Password	`7fa9d1e`	backend/src/ee/services/agent-vault-access-bundle/agent-vault-credential-write-fns.test.ts	View secret
38911126	Triggered	Username Password	`7fa9d1e`	backend/e2e-test/routes/v1/agent-vault.spec.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

…feat-agent-vault-mcp-proxy

initial implementation

748266a

sheensantoscapadngan changed the title ~~feat: MCP proxy~~ feature: Agent Vault MCP proxy Oct 15, 2026

greptile-apps Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread frontend/src/components/agent-vault/service-sheet/OAuthAuthorizeCard.tsx Resolved

Comment thread frontend/src/components/agent-vault/ServiceTemplateSelect.tsx Resolved

misc: addressed feedback

8404a2e

sheensantoscapadngan changed the title ~~feature: Agent Vault MCP proxy~~ feat: Agent Vault MCP proxy Oct 15, 2026

sheensantoscapadngan changed the title ~~feat: Agent Vault MCP proxy~~ feat: agent vault mcp server Oct 15, 2026

greptile-apps Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread backend/src/ee/routes/v1/agent-vault-routers/agent-vault-access-bundle-router.ts Resolved

docs: added initial

210c224

mintlify Bot deployed to staging - docs October 15, 2026 21:49

View deployment

greptile-apps Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread docs/documentation/platform/agent-vault/mcp-servers.mdx Resolved

saifsmailbox98 reviewed Oct 19, 2026

View reviewed changes

mintlify Bot deployed to staging - docs October 20, 2026 18:03

View deployment

saifsmailbox98 requested changes Oct 20, 2026

View reviewed changes

mintlify Bot deployed to staging - docs October 20, 2026 20:42

View deployment

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread frontend/src/components/agent-vault/service-sheet/OAuthAuthorizeCard.tsx Resolved

Comment thread backend/src/ee/services/agent-vault-access-bundle/agent-vault-access-bundle-service.ts Resolved

misc: addressed feedback

16bfbd7

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread backend/src/ee/routes/v1/agent-vault-routers/agent-vault-schemas.ts Resolved

misc: addressed more feedback

7f508d1

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-discovery-fns.ts Resolved

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-client-fns.ts Resolved

misc: addressed third batch of review comments

745f211

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-service.ts Resolved

misc: more feedback

8274187

misc: addressed greptile comments

3a30c57

mintlify Bot deployed to staging - docs October 22, 2026 17:22

View deployment

greptile-apps Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-http-fns.ts Resolved

Comment thread frontend/src/components/agent-vault/service-sheet/McpCredentialFields.tsx Resolved

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-client-fns.ts Resolved

misc: greptile

01a9572

greptile-apps Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-http-fns.ts Resolved

misc: polishing work

e170392

mintlify Bot deployed to staging - docs October 22, 2026 21:21

View deployment

saifsmailbox98 requested changes Oct 26, 2026

View reviewed changes

misc: address feedback

246ecd1

mintlify Bot deployed to staging - docs October 26, 2026 21:42

View deployment

greptile-apps Bot reviewed Oct 26, 2026

View reviewed changes

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-token-fns.ts Resolved

Comment thread frontend/src/components/agent-vault/service-sheet/OAuthAuthorizeCard.tsx Resolved

mintlify Bot deployed to staging - docs October 26, 2026 22:13

View deployment

greptile-apps Bot reviewed Oct 26, 2026

View reviewed changes

Comment thread frontend/src/components/agent-vault/service-sheet/OAuthAuthorizeCard.tsx Resolved

Comment thread docs/documentation/platform/agent-vault/mcp-servers.mdx Resolved

misc: more feedback

4fd2903

mintlify Bot deployed to staging - docs October 26, 2026 23:58

View deployment

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread frontend/src/hooks/api/agentVault/queries.tsx Resolved

Comment thread docs/documentation/platform/agent-vault/mcp-servers.mdx Resolved

misc: addressed failing checks

f7360c7

mintlify Bot deployed to staging - docs October 27, 2026 00:43

View deployment

saifsmailbox98 requested changes Oct 27, 2026

View reviewed changes

misc: addressed feedback

03f0b86

mintlify Bot deployed to staging - docs October 27, 2026 16:33

View deployment

Merge remote-tracking branch 'origin/main' into sheensantoscapadngan/…

838da8a

…feat-agent-vault-mcp-proxy

mintlify Bot deployed to staging - docs October 27, 2026 16:49

View deployment

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-service.ts Resolved

Comment thread backend/src/ee/services/agent-vault-oauth/agent-vault-oauth-discovery-fns.ts Resolved

saifsmailbox98 approved these changes Oct 27, 2026

View reviewed changes

sheensantoscapadngan merged commit 53715b5 into main Oct 27, 2026
22 of 24 checks passed

mintlify Bot mentioned this pull request Oct 27, 2026

docs(agent-vault): fix substitution link in modal guide #8970

Merged

3 of 11 tasks

Conversation

sheensantoscapadngan commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Screenshots

Steps to verify the change

Type

Checklist

Uh oh!

infisical-review-police Bot commented Oct 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026

Uh oh!

socket-security Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Findings

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mintlify Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

linear Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gitguardian Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

sheensantoscapadngan commented Oct 15, 2026 •

edited

Loading

socket-security Bot commented Oct 15, 2026 •

edited

Loading

greptile-apps Bot commented Oct 15, 2026 •

edited

Loading

mintlify Bot commented Oct 15, 2026 •

edited

Loading

linear Bot commented Oct 26, 2026 •

edited

Loading

gitguardian Bot commented Oct 26, 2026 •

edited

Loading