Repository navigation
[P2] Upgrade safe-settings 2.1.17 → 2.1.19 #5
Description
Why
probot v14 was fixed in 2.1.19 via PR #949. The 3 remaining bugs are already worked around in this repo.
Merge checklist
- Dry-run from branch:
gh workflow run safe-settings-sync.yml --ref <branch> -f nop=true - Dry-run output clean (no unexpected diffs)
- No regression on bypass / contexts / suborgs
Audit report — section 5
Activity
chore: upgrade safe-settings to 2.1.19, harden workflow
chore: upgrade safe-settings to 2.1.19, harden workflow
nbrieussel commentedon Apr 14, 2026
Update 2026-04-14: 2.1.19 tested — NOT safe to upgrade
Tested in PR #15 dry-run gate. 2.1.19 crashes immediately on boot:
PR #949 fixed the octokit
.rest.*namespace calls butcreateProbot()still initializes the probot logger as null beforeperformFullSyncruns. The crash happens before any settings are read.Reverted back to 2.1.17 in both
safe-settings-sync.ymlandpr-dry-run.yml. This issue remains open — upgrade only once a version that actually boots cleanly in NOP mode is identified.