Fix flaky media seek test (forward playback drift on JFX 25)#117
Merged
Conversation
seek_after_media_player_reached_eom seeks while playing, so current time drifts forward past the target during the wait. Assert a forward-tolerant range for that case instead of symmetric closeness. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JavaFX 21+ converts the seek Duration to CMTime with timescale 1 on macOS, so seeks snap ~0.5s off (exact on JFX 17). The seek-based tests can't pass there until fixed upstream. CI runs media tests on ubuntu only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaPlayerTests.seek_after_media_player_reached_eomseeks toduration - 2swhile playing, sogetCurrentTime()drifts forward past the seek target duringwaitForFxEvents()(134 ms observed on JFX 25, vs ≤50 ms on JFX 17). The existing symmetricwithin(50 ms)tolerance from #110 then fails intermittently.This swaps that one assertion for a forward-tolerant range (
[seekTime − 50 ms, seekTime + 1 s]) since a playing seek lands at the target and only advances forward. The three ready/paused seek assertions keep the exact-closeness check unchanged.🤖 Generated with Claude Code