crawlRoute bootstraps the SimpleFX core itself#121
Merged
Conversation
Callers no longer need an inFX/FXCoreInitListener step before crawling; crawlRoute initializes the SimpleFX core (on the FX thread) so an off-FX-thread call doesn't fail with "Core was first triggered from thread ...". Adds a cold-start test (forkEvery=1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppCrawler.crawlRoutenow initializes the SimpleFX core (on the FX thread) before crawling, so callers (leak tests, sitemap crawls, etc.) no longer need aninFX/FXCoreInitListenerstep — without it, the first off-FX-thread touch fails with"Core was first triggered from thread ...". AddsTestCrawlInitializesCore(cold-start,forkEvery=1for JVM isolation).🤖 Generated with Claude Code